From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3692C77B7C for ; Thu, 20 Apr 2023 11:07:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235280AbjDTLHd (ORCPT ); Thu, 20 Apr 2023 07:07:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54448 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234611AbjDTLFi (ORCPT ); Thu, 20 Apr 2023 07:05:38 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E7E4283F5; Thu, 20 Apr 2023 04:04:05 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1E5D9647CD; Thu, 20 Apr 2023 11:03:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D3B58C433EF; Thu, 20 Apr 2023 11:03:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681988612; bh=NZrnd8QS9D7YxLacsJYmOPmK2ytxRfYPCgRmL+pnBik=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BPkd7qxcY/+BMgd3Myt8m284Agj0tSZJ33KrcZ6CCL4xCKNlDvfHPZMGqSrkN/jpO o0nD9I8f/FB6ANIltnIJUDynKRbQZXsviRlU/PRY1/UfGO6JLl/oBq/k/xrzua+PKK uxsjK7Lb77JPyPwzFDIYOaGA9TaxdJtwGKuM+TMBC+ja9fWMCWdA7cM6aps5OXH6aX tWL6fXL4hHro+x249UAjJTE+Aq3+ozxZYmQlPpc6c2sRXZaH1VaInDvKWm2IiCRmAP jraN8bEIakaeLDltFIxuGv5T3nhZVUYDvcXOzik57g5FbEm3OvT7iTdmOxAyBdF8xZ KgXCD6b9jBD8Q== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: =?UTF-8?q?Patrik=20Dahlstr=C3=B6m?= , Jonathan Cameron , Sasha Levin , jic23@kernel.org, linux-iio@vger.kernel.org Subject: [PATCH AUTOSEL 5.10 2/3] iio: adc: palmas_gpadc: fix NULL dereference on rmmod Date: Thu, 20 Apr 2023 07:03:23 -0400 Message-Id: <20230420110326.506279-2-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230420110326.506279-1-sashal@kernel.org> References: <20230420110326.506279-1-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Patrik Dahlström [ Upstream commit 49f76c499d38bf67803438eee88c8300d0f6ce09 ] Calling dev_to_iio_dev() on a platform device pointer is undefined and will make adc NULL. Signed-off-by: Patrik Dahlström Link: https://lore.kernel.org/r/20230313205029.1881745-1-risca@dalakolonin.se Signed-off-by: Jonathan Cameron Signed-off-by: Sasha Levin --- drivers/iio/adc/palmas_gpadc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/adc/palmas_gpadc.c b/drivers/iio/adc/palmas_gpadc.c index f4756671cddb6..6ed0d151ad21a 100644 --- a/drivers/iio/adc/palmas_gpadc.c +++ b/drivers/iio/adc/palmas_gpadc.c @@ -628,7 +628,7 @@ static int palmas_gpadc_probe(struct platform_device *pdev) static int palmas_gpadc_remove(struct platform_device *pdev) { - struct iio_dev *indio_dev = dev_to_iio_dev(&pdev->dev); + struct iio_dev *indio_dev = dev_get_drvdata(&pdev->dev); struct palmas_gpadc *adc = iio_priv(indio_dev); if (adc->wakeup1_enable || adc->wakeup2_enable) -- 2.39.2