* [PATCH] iio: imu: inv_icm42600: fix timestamp reset
@ 2023-05-03 20:44 inv.git-commit
2023-05-06 18:10 ` Jonathan Cameron
0 siblings, 1 reply; 4+ messages in thread
From: inv.git-commit @ 2023-05-03 20:44 UTC (permalink / raw)
To: jic23, linux-iio; +Cc: lars, Jean-Baptiste Maneyrol, inv.git-commit, stable
From: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com>
Timestamp reset is not done in the correct place. It must be done
before enabling buffer. The reason is that interrupt timestamping
is always happening when the chip is on, even if the
corresponding sensor is off. When the sensor restarts, timestamp
is wrong if you don't do a reset first.
Fixes: ec74ae9fd37c ("iio: imu: inv_icm42600: add accurate timestamping")
Signed-off-by: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com>
Signed-off-by: <inv.git-commit@tdk.com>
Cc: <stable@vger.kernel.org>
---
drivers/iio/imu/inv_icm42600/inv_icm42600_buffer.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/iio/imu/inv_icm42600/inv_icm42600_buffer.c b/drivers/iio/imu/inv_icm42600/inv_icm42600_buffer.c
index 99576b2c171f..32d7f8364230 100644
--- a/drivers/iio/imu/inv_icm42600/inv_icm42600_buffer.c
+++ b/drivers/iio/imu/inv_icm42600/inv_icm42600_buffer.c
@@ -275,9 +275,14 @@ static int inv_icm42600_buffer_preenable(struct iio_dev *indio_dev)
{
struct inv_icm42600_state *st = iio_device_get_drvdata(indio_dev);
struct device *dev = regmap_get_device(st->map);
+ struct inv_icm42600_timestamp *ts = iio_priv(indio_dev);
pm_runtime_get_sync(dev);
+ mutex_lock(&st->lock);
+ inv_icm42600_timestamp_reset(ts);
+ mutex_unlock(&st->lock);
+
return 0;
}
@@ -375,7 +380,6 @@ static int inv_icm42600_buffer_postdisable(struct iio_dev *indio_dev)
struct device *dev = regmap_get_device(st->map);
unsigned int sensor;
unsigned int *watermark;
- struct inv_icm42600_timestamp *ts;
struct inv_icm42600_sensor_conf conf = INV_ICM42600_SENSOR_CONF_INIT;
unsigned int sleep_temp = 0;
unsigned int sleep_sensor = 0;
@@ -385,11 +389,9 @@ static int inv_icm42600_buffer_postdisable(struct iio_dev *indio_dev)
if (indio_dev == st->indio_gyro) {
sensor = INV_ICM42600_SENSOR_GYRO;
watermark = &st->fifo.watermark.gyro;
- ts = iio_priv(st->indio_gyro);
} else if (indio_dev == st->indio_accel) {
sensor = INV_ICM42600_SENSOR_ACCEL;
watermark = &st->fifo.watermark.accel;
- ts = iio_priv(st->indio_accel);
} else {
return -EINVAL;
}
@@ -417,8 +419,6 @@ static int inv_icm42600_buffer_postdisable(struct iio_dev *indio_dev)
if (!st->fifo.on)
ret = inv_icm42600_set_temp_conf(st, false, &sleep_temp);
- inv_icm42600_timestamp_reset(ts);
-
out_unlock:
mutex_unlock(&st->lock);
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] iio: imu: inv_icm42600: fix timestamp reset
2023-05-03 20:44 [PATCH] iio: imu: inv_icm42600: fix timestamp reset inv.git-commit
@ 2023-05-06 18:10 ` Jonathan Cameron
2023-05-09 10:27 ` Jean-Baptiste Maneyrol
0 siblings, 1 reply; 4+ messages in thread
From: Jonathan Cameron @ 2023-05-06 18:10 UTC (permalink / raw)
To: inv.git-commit; +Cc: linux-iio, lars, Jean-Baptiste Maneyrol, stable
On Wed, 3 May 2023 20:44:10 +0000
inv.git-commit@tdk.com wrote:
> From: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com>
>
> Timestamp reset is not done in the correct place. It must be done
> before enabling buffer. The reason is that interrupt timestamping
> is always happening when the chip is on, even if the
> corresponding sensor is off. When the sensor restarts, timestamp
> is wrong if you don't do a reset first.
>
> Fixes: ec74ae9fd37c ("iio: imu: inv_icm42600: add accurate timestamping")
> Signed-off-by: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com>
> Signed-off-by: <inv.git-commit@tdk.com>
What's this sign off?
> Cc: <stable@vger.kernel.org>
Otherwise patch looks fine.
Jonathan
> ---
> drivers/iio/imu/inv_icm42600/inv_icm42600_buffer.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/iio/imu/inv_icm42600/inv_icm42600_buffer.c b/drivers/iio/imu/inv_icm42600/inv_icm42600_buffer.c
> index 99576b2c171f..32d7f8364230 100644
> --- a/drivers/iio/imu/inv_icm42600/inv_icm42600_buffer.c
> +++ b/drivers/iio/imu/inv_icm42600/inv_icm42600_buffer.c
> @@ -275,9 +275,14 @@ static int inv_icm42600_buffer_preenable(struct iio_dev *indio_dev)
> {
> struct inv_icm42600_state *st = iio_device_get_drvdata(indio_dev);
> struct device *dev = regmap_get_device(st->map);
> + struct inv_icm42600_timestamp *ts = iio_priv(indio_dev);
>
> pm_runtime_get_sync(dev);
>
> + mutex_lock(&st->lock);
> + inv_icm42600_timestamp_reset(ts);
> + mutex_unlock(&st->lock);
> +
> return 0;
> }
>
> @@ -375,7 +380,6 @@ static int inv_icm42600_buffer_postdisable(struct iio_dev *indio_dev)
> struct device *dev = regmap_get_device(st->map);
> unsigned int sensor;
> unsigned int *watermark;
> - struct inv_icm42600_timestamp *ts;
> struct inv_icm42600_sensor_conf conf = INV_ICM42600_SENSOR_CONF_INIT;
> unsigned int sleep_temp = 0;
> unsigned int sleep_sensor = 0;
> @@ -385,11 +389,9 @@ static int inv_icm42600_buffer_postdisable(struct iio_dev *indio_dev)
> if (indio_dev == st->indio_gyro) {
> sensor = INV_ICM42600_SENSOR_GYRO;
> watermark = &st->fifo.watermark.gyro;
> - ts = iio_priv(st->indio_gyro);
> } else if (indio_dev == st->indio_accel) {
> sensor = INV_ICM42600_SENSOR_ACCEL;
> watermark = &st->fifo.watermark.accel;
> - ts = iio_priv(st->indio_accel);
> } else {
> return -EINVAL;
> }
> @@ -417,8 +419,6 @@ static int inv_icm42600_buffer_postdisable(struct iio_dev *indio_dev)
> if (!st->fifo.on)
> ret = inv_icm42600_set_temp_conf(st, false, &sleep_temp);
>
> - inv_icm42600_timestamp_reset(ts);
> -
> out_unlock:
> mutex_unlock(&st->lock);
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] iio: imu: inv_icm42600: fix timestamp reset
2023-05-06 18:10 ` Jonathan Cameron
@ 2023-05-09 10:27 ` Jean-Baptiste Maneyrol
2023-05-09 13:58 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Jean-Baptiste Maneyrol @ 2023-05-09 10:27 UTC (permalink / raw)
To: Jonathan Cameron, INV Git Commit
Cc: linux-iio@vger.kernel.org, lars@metafoo.de,
stable@vger.kernel.org
Hi Jonathan,
the signed off is for the email address we are using for sending email to the mailing list.
We cannot use our personal email address, so we are obliged to use a dedicated service account for sending email with the git send-email tool.
Should I delete the signed-off corresponding to that email address?
Thanks,
JB
From: Jonathan Cameron <jic23@kernel.org>
Sent: Saturday, May 6, 2023 20:10
To: INV Git Commit <INV.git-commit@tdk.com>
Cc: linux-iio@vger.kernel.org <linux-iio@vger.kernel.org>; lars@metafoo.de <lars@metafoo.de>; Jean-Baptiste Maneyrol <Jean-Baptiste.Maneyrol@tdk.com>; stable@vger.kernel.org <stable@vger.kernel.org>
Subject: Re: [PATCH] iio: imu: inv_icm42600: fix timestamp reset
[CAUTION] This is an EXTERNAL email. Do not click links or open attachments unless you recognize the sender and know the content is safe.
======================================================================
On Wed, 3 May 2023 20:44:10 +0000
inv.git-commit@tdk.com wrote:
> From: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com>
>
> Timestamp reset is not done in the correct place. It must be done
> before enabling buffer. The reason is that interrupt timestamping
> is always happening when the chip is on, even if the
> corresponding sensor is off. When the sensor restarts, timestamp
> is wrong if you don't do a reset first.
>
> Fixes: ec74ae9fd37c ("iio: imu: inv_icm42600: add accurate timestamping")
> Signed-off-by: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com>
> Signed-off-by: <inv.git-commit@tdk.com>
What's this sign off?
> Cc: <stable@vger.kernel.org>
Otherwise patch looks fine.
Jonathan
> ---
> drivers/iio/imu/inv_icm42600/inv_icm42600_buffer.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/iio/imu/inv_icm42600/inv_icm42600_buffer.c b/drivers/iio/imu/inv_icm42600/inv_icm42600_buffer.c
> index 99576b2c171f..32d7f8364230 100644
> --- a/drivers/iio/imu/inv_icm42600/inv_icm42600_buffer.c
> +++ b/drivers/iio/imu/inv_icm42600/inv_icm42600_buffer.c
> @@ -275,9 +275,14 @@ static int inv_icm42600_buffer_preenable(struct iio_dev *indio_dev)
> {
> struct inv_icm42600_state *st = iio_device_get_drvdata(indio_dev);
> struct device *dev = regmap_get_device(st->map);
> + struct inv_icm42600_timestamp *ts = iio_priv(indio_dev);
>
> pm_runtime_get_sync(dev);
>
> + mutex_lock(&st->lock);
> + inv_icm42600_timestamp_reset(ts);
> + mutex_unlock(&st->lock);
> +
> return 0;
> }
>
> @@ -375,7 +380,6 @@ static int inv_icm42600_buffer_postdisable(struct iio_dev *indio_dev)
> struct device *dev = regmap_get_device(st->map);
> unsigned int sensor;
> unsigned int *watermark;
> - struct inv_icm42600_timestamp *ts;
> struct inv_icm42600_sensor_conf conf = INV_ICM42600_SENSOR_CONF_INIT;
> unsigned int sleep_temp = 0;
> unsigned int sleep_sensor = 0;
> @@ -385,11 +389,9 @@ static int inv_icm42600_buffer_postdisable(struct iio_dev *indio_dev)
> if (indio_dev == st->indio_gyro) {
> sensor = INV_ICM42600_SENSOR_GYRO;
> watermark = &st->fifo.watermark.gyro;
> - ts = iio_priv(st->indio_gyro);
> } else if (indio_dev == st->indio_accel) {
> sensor = INV_ICM42600_SENSOR_ACCEL;
> watermark = &st->fifo.watermark.accel;
> - ts = iio_priv(st->indio_accel);
> } else {
> return -EINVAL;
> }
> @@ -417,8 +419,6 @@ static int inv_icm42600_buffer_postdisable(struct iio_dev *indio_dev)
> if (!st->fifo.on)
> ret = inv_icm42600_set_temp_conf(st, false, &sleep_temp);
>
> - inv_icm42600_timestamp_reset(ts);
> -
> out_unlock:
> mutex_unlock(&st->lock);
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] iio: imu: inv_icm42600: fix timestamp reset
2023-05-09 10:27 ` Jean-Baptiste Maneyrol
@ 2023-05-09 13:58 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2023-05-09 13:58 UTC (permalink / raw)
To: Jean-Baptiste Maneyrol
Cc: Jonathan Cameron, INV Git Commit, linux-iio@vger.kernel.org,
lars@metafoo.de, stable@vger.kernel.org
On Tue, May 09, 2023 at 10:27:31AM +0000, Jean-Baptiste Maneyrol wrote:
> Hi Jonathan,
>
> the signed off is for the email address we are using for sending email to the mailing list.
Please read the documentation for what Signed-off-by: means, it is NOT
for email aliases, it is a legal statement.
Please remove it when you resend.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-05-09 13:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-03 20:44 [PATCH] iio: imu: inv_icm42600: fix timestamp reset inv.git-commit
2023-05-06 18:10 ` Jonathan Cameron
2023-05-09 10:27 ` Jean-Baptiste Maneyrol
2023-05-09 13:58 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).