From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DB22C77B75 for ; Sun, 7 May 2023 13:08:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229578AbjEGNIa (ORCPT ); Sun, 7 May 2023 09:08:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52884 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229454AbjEGNI3 (ORCPT ); Sun, 7 May 2023 09:08:29 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C451524D for ; Sun, 7 May 2023 06:08:28 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D41B060C04 for ; Sun, 7 May 2023 13:08:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DF142C433EF; Sun, 7 May 2023 13:08:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1683464907; bh=tEyvWEDOPso8aUfuBDy7QzH5zD6QEJ7nP3Md/PYtpIU=; h=Subject:To:Cc:From:Date:From; b=l+/Zzh5lN2mTL1eYF99ox8lWjuxFBoBU6Z/inN2AjKISstGCCB66KeJtm0+stS5/8 7MrDxbkyetmVCxb8FYWtW1lbgbKUfoAuuJm0FAQA6AqfQR0I5uTmXVR++ES5JMnSX3 5PAG43mx19mMnygheLfw2UNg3QDo6VWyIAmCrcBE= Subject: FAILED: patch "[PATCH] btrfs: set default discard iops_limit to 1000" failed to apply to 6.3-stable tree To: boris@bur.io, dsterba@suse.com, neal@gompa.dev Cc: From: Date: Sun, 07 May 2023 15:08:24 +0200 Message-ID: <2023050724-striving-matter-4a91@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org The patch below does not apply to the 6.3-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.3.y git checkout FETCH_HEAD git cherry-pick -x cfe3445a58658b2a142a9ba5f5de69d91c56a297 # git commit -s git send-email --to '' --in-reply-to '2023050724-striving-matter-4a91@gregkh' --subject-prefix 'PATCH 6.3.y' HEAD^.. Possible dependencies: cfe3445a5865 ("btrfs: set default discard iops_limit to 1000") thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From cfe3445a58658b2a142a9ba5f5de69d91c56a297 Mon Sep 17 00:00:00 2001 From: Boris Burkov Date: Wed, 5 Apr 2023 12:43:58 -0700 Subject: [PATCH] btrfs: set default discard iops_limit to 1000 Previously, the default was a relatively conservative 10. This results in a 100ms delay, so with ~300 discards in a commit, it takes the full 30s till the next commit to finish the discards. On a workstation, this results in the disk never going idle, wasting power/battery, etc. Set the default to 1000, which results in using the smallest possible delay, currently, which is 1ms. This has shown to not pathologically keep the disk busy by the original reporter. Link: https://lore.kernel.org/linux-btrfs/Y%2F+n1wS%2F4XAH7X1p@nz/ Link: https://bugzilla.redhat.com/show_bug.cgi?id=2182228 CC: stable@vger.kernel.org # 6.2+ Reviewed-by: Neal Gompa Reviewed-by: David Sterba Signed-off-by: David Sterba diff --git a/fs/btrfs/discard.c b/fs/btrfs/discard.c index 317aeff6c1da..0bc526f5fcd9 100644 --- a/fs/btrfs/discard.c +++ b/fs/btrfs/discard.c @@ -60,7 +60,7 @@ #define BTRFS_DISCARD_TARGET_MSEC (6 * 60 * 60UL * MSEC_PER_SEC) #define BTRFS_DISCARD_MIN_DELAY_MSEC (1UL) #define BTRFS_DISCARD_MAX_DELAY_MSEC (1000UL) -#define BTRFS_DISCARD_MAX_IOPS (10U) +#define BTRFS_DISCARD_MAX_IOPS (1000U) /* Monotonically decreasing minimum length filters after index 0 */ static int discard_minlen[BTRFS_NR_DISCARD_LISTS] = {