From: Greg KH <gregkh@linuxfoundation.org>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: stable@vger.kernel.org
Subject: Re: [PATCH 5.10.y 1/2] arm64: Always load shadow stack pointer directly from the task struct
Date: Sun, 7 May 2023 07:11:11 +0200 [thread overview]
Message-ID: <2023050757-starless-tacking-d9f9@gregkh> (raw)
In-Reply-To: <20230506123434.63470-1-ardb@kernel.org>
On Sat, May 06, 2023 at 02:34:33PM +0200, Ard Biesheuvel wrote:
> All occurrences of the scs_load macro load the value of the shadow call
> stack pointer from the task which is current at that point. So instead
> of taking a task struct register argument in the scs_load macro to
> specify the task struct to load from, let's always reference the current
> task directly. This should make it much harder to exploit any
> instruction sequences reloading the shadow call stack pointer register
> from memory.
>
> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> Acked-by: Mark Rutland <mark.rutland@arm.com>
> Reviewed-by: Kees Cook <keescook@chromium.org>
> Link: https://lore.kernel.org/r/20230109174800.3286265-2-ardb@kernel.org
> Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> ---
> arch/arm64/include/asm/scs.h | 7 ++++---
> arch/arm64/kernel/entry.S | 4 ++--
> arch/arm64/kernel/head.S | 2 +-
> 3 files changed, 7 insertions(+), 6 deletions(-)
What is the git commit id of this in Linus's tree?
thanks,
greg k-h
next prev parent reply other threads:[~2023-05-07 5:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-06 12:34 [PATCH 5.10.y 1/2] arm64: Always load shadow stack pointer directly from the task struct Ard Biesheuvel
2023-05-06 12:34 ` [PATCH 5.10.y 2/2] arm64: Stash shadow stack pointer in the task struct on interrupt Ard Biesheuvel
2023-05-07 5:11 ` Greg KH [this message]
2023-05-07 8:11 ` [PATCH 5.10.y 1/2] arm64: Always load shadow stack pointer directly from the task struct Ard Biesheuvel
2023-05-08 6:57 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023050757-starless-tacking-d9f9@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=ardb@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox