From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92C7BC7EE22 for ; Tue, 9 May 2023 03:59:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234789AbjEID7d (ORCPT ); Mon, 8 May 2023 23:59:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38652 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234790AbjEID6u (ORCPT ); Mon, 8 May 2023 23:58:50 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AED76E6D; Mon, 8 May 2023 20:56:45 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 23FEE643FA; Tue, 9 May 2023 03:56:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7B41FC433B4; Tue, 9 May 2023 03:56:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683604602; bh=QUCTBzOnd+PYrLHNFSvXd4hfpFxpRpbxuQrbB42Nxsw=; h=From:To:Cc:Subject:Date:From; b=jwrye0+N0h8xrnrxy7YhEcPPOICzKU9pvOrIuYgDreIh8mdNdcx2Fl6rokY0ioF6p d7hYvTeqGnF1rnbuEuxytpIqY6HC31l0zLK5fLRD79koM16kQtSwNFFocNHTlADRtB uXIWwKTlFQICdOmUkR5TjXItZDG0924Rhcb/1NkXYDmEh+qQ73+rm0NNObib9Zg/Cv BiMKw51sbb4jFDfg5XpwKXVIKd++qwqgWHiwquebkNjILYaAKKPvoZajXCWXdR7/9Y qt6JP7DRl/j/cX+9K6EvgIpsl5a5DuTeLy+clwKSxHejYTxXFk0Bt/oPr17NpPH6X1 7kFXkWElBt4HA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Josh Poimboeuf , Peter Zijlstra , Sasha Levin Subject: [PATCH AUTOSEL 4.14 1/2] sched: Fix KCSAN noinstr violation Date: Mon, 8 May 2023 23:56:35 -0400 Message-Id: <20230509035641.61093-1-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Josh Poimboeuf [ Upstream commit e0b081d17a9f4e5c0cbb0e5fbeb1abe3de0f7e4e ] With KCSAN enabled, end_of_stack() can get out-of-lined. Force it inline. Fixes the following warnings: vmlinux.o: warning: objtool: check_stackleak_irqoff+0x2b: call to end_of_stack() leaves .noinstr.text section Signed-off-by: Josh Poimboeuf Signed-off-by: Peter Zijlstra (Intel) Link: https://lore.kernel.org/r/cc1b4d73d3a428a00d206242a68fdf99a934ca7b.1681320026.git.jpoimboe@kernel.org Signed-off-by: Sasha Levin --- include/linux/sched/task_stack.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/sched/task_stack.h b/include/linux/sched/task_stack.h index 3461beb89b040..62d1cd4db27af 100644 --- a/include/linux/sched/task_stack.h +++ b/include/linux/sched/task_stack.h @@ -23,7 +23,7 @@ static inline void *task_stack_page(const struct task_struct *task) #define setup_thread_stack(new,old) do { } while(0) -static inline unsigned long *end_of_stack(const struct task_struct *task) +static __always_inline unsigned long *end_of_stack(const struct task_struct *task) { #ifdef CONFIG_STACK_GROWSUP return (unsigned long *)((unsigned long)task->stack + THREAD_SIZE) - 1; -- 2.39.2