From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56380C77B7D for ; Wed, 10 May 2023 20:52:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237234AbjEJUw1 (ORCPT ); Wed, 10 May 2023 16:52:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42690 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237083AbjEJUvy (ORCPT ); Wed, 10 May 2023 16:51:54 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F50583CE; Wed, 10 May 2023 13:51:25 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BCA4C649EE; Wed, 10 May 2023 20:51:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 063BEC433A1; Wed, 10 May 2023 20:51:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683751866; bh=xqECVp95j0ASjkgq/jmJaVtAt5Mj5ws54d3kcCXk9os=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lbOCrK9tKZb7PuqKmc08CBqoS5mxrxJE1zX5LZNZOlGdQkFy3EmbQyWycBjcfserv s3M/v//Do1NbXfzF4PbhN6e3F6Ac5pqTZ5k0y7nxnRmC77iPwW+XSA62L0LOm8SZBQ CN9QRt121LLB6pYtyLdTlxfjVqkQ0QlDvz4NuQqQ9gqHALLICP3rXfPFD7pzAMbETS UoT/PR79QioyjC/gNVeCV6sdyGSMYdc88tHK8pEe3qHAEPGv5kRyKUVh6DEqT21SEw kOg/VBdUkZ8ffj1y1Sf9Ynv88mB4cdzTnVnjRJbvIRj0IaAxDasVxSZXrDO7RqazOa XehNoZ07dTKgQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Qiang Ning , Lee Jones , Sasha Levin Subject: [PATCH AUTOSEL 4.14 2/2] mfd: dln2: Fix memory leak in dln2_probe() Date: Wed, 10 May 2023 16:50:54 -0400 Message-Id: <20230510205054.105151-2-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230510205054.105151-1-sashal@kernel.org> References: <20230510205054.105151-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Qiang Ning [ Upstream commit 96da8f148396329ba769246cb8ceaa35f1ddfc48 ] When dln2_setup_rx_urbs() in dln2_probe() fails, error out_free forgets to call usb_put_dev() to decrease the refcount of dln2->usb_dev. Fix this by adding usb_put_dev() in the error handling code of dln2_probe(). Signed-off-by: Qiang Ning Signed-off-by: Lee Jones Link: https://lore.kernel.org/r/20230330024353.4503-1-qning0106@126.com Signed-off-by: Sasha Levin --- drivers/mfd/dln2.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mfd/dln2.c b/drivers/mfd/dln2.c index 97a69cd6f1278..a0ad99ca495fd 100644 --- a/drivers/mfd/dln2.c +++ b/drivers/mfd/dln2.c @@ -804,6 +804,7 @@ static int dln2_probe(struct usb_interface *interface, dln2_stop_rx_urbs(dln2); out_free: + usb_put_dev(dln2->usb_dev); dln2_free(dln2); return ret; -- 2.39.2