From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E3CEC7EE24 for ; Mon, 15 May 2023 18:08:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245053AbjEOSIV (ORCPT ); Mon, 15 May 2023 14:08:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44764 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245056AbjEOSHM (ORCPT ); Mon, 15 May 2023 14:07:12 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 64C751BB81 for ; Mon, 15 May 2023 11:04:39 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 116DB630AD for ; Mon, 15 May 2023 18:04:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1C8C1C433EF; Mon, 15 May 2023 18:04:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1684173878; bh=Cd4eGKbEC6w3b7AyxXC7nFJ9oPxOZbY3+/Kkp9cPs8s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=E9X4oD20Ym1rd5SdPFGQvPM7UmfNDOjeP+TK2F592gH94zooTIMfXzvevj5WBAZka A3FGKryMqlj8GPMAyGBTlBAtCpoOBI/RBoB8OjtGwhQ66B95vwcf3V8jb1tTjg4dSx goqwYaKkM1xdGwO9HI2GlJxyMfPFYMKvlP1H7oi8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Mike Snitzer Subject: [PATCH 5.4 204/282] dm integrity: call kmem_cache_destroy() in dm_integrity_init() error path Date: Mon, 15 May 2023 18:29:42 +0200 Message-Id: <20230515161728.365540462@linuxfoundation.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230515161722.146344674@linuxfoundation.org> References: <20230515161722.146344674@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Mike Snitzer commit 6b79a428c02769f2a11f8ae76bf866226d134887 upstream. Otherwise the journal_io_cache will leak if dm_register_target() fails. Cc: stable@vger.kernel.org Signed-off-by: Mike Snitzer Signed-off-by: Greg Kroah-Hartman --- drivers/md/dm-integrity.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) --- a/drivers/md/dm-integrity.c +++ b/drivers/md/dm-integrity.c @@ -4288,11 +4288,13 @@ static int __init dm_integrity_init(void } r = dm_register_target(&integrity_target); - - if (r < 0) + if (r < 0) { DMERR("register failed %d", r); + kmem_cache_destroy(journal_io_cache); + return r; + } - return r; + return 0; } static void __exit dm_integrity_exit(void)