From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21C5CC7EE24 for ; Mon, 15 May 2023 18:09:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245177AbjEOSJT (ORCPT ); Mon, 15 May 2023 14:09:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44764 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245142AbjEOSIx (ORCPT ); Mon, 15 May 2023 14:08:53 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 10D351994D for ; Mon, 15 May 2023 11:06:43 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9AC44630E5 for ; Mon, 15 May 2023 18:06:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 95719C433D2; Mon, 15 May 2023 18:06:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1684174002; bh=B/bAqrSB3C2f4YL3jVbpj8jICGWmWfxbQOQ18kxBjQE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IpdiPZujqR4hXA0bnycLVej2qGPthqlKDhw4hkDhJ6Ale1PnLeRV9TxYgm83flazX 4tL0dJK5JPzyhVNhYbafmlP42okpvNV28+GbI4aqzlbRz61vED3bcnGoi7RUrq9upS scaVc0T17oiZmeSRiUYOgm6Ml+hniLJvkAUOqTeQ= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Zhang Qilong , Mark Brown Subject: [PATCH 5.4 276/282] spi: imx: fix reference leak in two imx operations Date: Mon, 15 May 2023 18:30:54 +0200 Message-Id: <20230515161730.648023288@linuxfoundation.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230515161722.146344674@linuxfoundation.org> References: <20230515161722.146344674@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Zhang Qilong commit 1dcbdd944824369d4569959f8130336fe6fe5f39 upstream. pm_runtime_get_sync will increment pm usage counter even it failed. Forgetting to pm_runtime_put_noidle will result in reference leak in callers(spi_imx_prepare_message and spi_imx_remove), so we should fix it. Fixes: 525c9e5a32bd7 ("spi: imx: enable runtime pm support") Signed-off-by: Zhang Qilong Link: https://lore.kernel.org/r/20201102145835.4765-1-zhangqilong3@huawei.com Signed-off-by: Mark Brown Signed-off-by: Greg Kroah-Hartman --- drivers/spi/spi-imx.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/spi/spi-imx.c +++ b/drivers/spi/spi-imx.c @@ -1538,6 +1538,7 @@ spi_imx_prepare_message(struct spi_maste ret = pm_runtime_resume_and_get(spi_imx->dev); if (ret < 0) { + pm_runtime_put_noidle(spi_imx->dev); dev_err(spi_imx->dev, "failed to enable clock\n"); return ret; }