From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id E42E9C77B7D
	for <stable@archiver.kernel.org>; Wed, 17 May 2023 14:02:46 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S230272AbjEQOCp (ORCPT <rfc822;stable@archiver.kernel.org>);
        Wed, 17 May 2023 10:02:45 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59090 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S230120AbjEQOCp (ORCPT
        <rfc822;stable@vger.kernel.org>); Wed, 17 May 2023 10:02:45 -0400
Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7306B121
        for <stable@vger.kernel.org>; Wed, 17 May 2023 07:02:44 -0700 (PDT)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by dfw.source.kernel.org (Postfix) with ESMTPS id 08BCD64790
        for <stable@vger.kernel.org>; Wed, 17 May 2023 14:02:44 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1F751C433EF;
        Wed, 17 May 2023 14:02:42 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
        s=korg; t=1684332163;
        bh=bSCxWydJy8/HPHf9yDf7oLL9CwsP7/nLvZ9Kd5bfH5Q=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=WCRAUTqA2I9teC08IKMsfKES0myGECyASkwemwlKn+YnsgLDKvjnVFZJ3P1xosaWk
         qAchTkeje9mfHHBX5oeBuLAV07pijN7NtuiNkdJNtypJKmlergm2OvHgAradTJvglH
         dmtjLFG/k+HO1J6ugKFtkNs8j7D2mFKWZxGkhW5E=
Date:   Wed, 17 May 2023 16:02:35 +0200
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Ben Hutchings <ben@decadent.org.uk>
Cc:     stable@vger.kernel.org, patches@lists.linux.dev,
        Sean Christopherson <seanjc@google.com>,
        Brijesh Singh <brijesh.singh@amd.com>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Sasha Levin <sashal@kernel.org>,
        Julien Cristau <jcristau@debian.org>
Subject: Re: [PATCH 5.10 076/529] crypto: ccp: Use the stack for small SEV
 command buffers
Message-ID: <2023051720-studied-plutonium-7fa8@gregkh>
References: <20230310133804.978589368@linuxfoundation.org>
 <20230310133808.495306749@linuxfoundation.org>
 <80d3ba7a1b8b7d65713f66ca3562a5ec4971c5ee.camel@decadent.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <80d3ba7a1b8b7d65713f66ca3562a5ec4971c5ee.camel@decadent.org.uk>
Precedence: bulk
List-ID: <stable.vger.kernel.org>
X-Mailing-List: stable@vger.kernel.org

On Wed, May 17, 2023 at 02:56:21PM +0200, Ben Hutchings wrote:
> On Fri, 2023-03-10 at 14:33 +0100, Greg Kroah-Hartman wrote:
> > From: Sean Christopherson <seanjc@google.com>
> > 
> > [ Upstream commit e4a9af799e5539b0feb99571f0aaed5a3c81dc5a ]
> > 
> > For commands with small input/output buffers, use the local stack to
> > "allocate" the structures used to communicate with the PSP.   Now that
> > __sev_do_cmd_locked() gracefully handles vmalloc'd buffers, there's no
> > reason to avoid using the stack, e.g. CONFIG_VMAP_STACK=y will just work.
> [...]
> 
> Julien Cristau reported a regression in ccp - the
> WARN_ON_ONCE(!virt_addr_valid(data)) is now being triggered.  I believe
> this was introduced by the above commit, which depends on:
> 
> commit 8347b99473a313be6549a5b940bc3c56a71be81c
> Author: Sean Christopherson <seanjc@google.com>
> Date:   Tue Apr 6 15:49:48 2021 -0700
>  
>     crypto: ccp: Play nice with vmalloc'd memory for SEV command structs
> 
> Ben.
> 

Thanks for letting me know, now queued up.

greg k-h