From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47E80C7EE2E for ; Wed, 24 May 2023 16:05:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229752AbjEXQFT (ORCPT ); Wed, 24 May 2023 12:05:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60830 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238753AbjEXQFB (ORCPT ); Wed, 24 May 2023 12:05:01 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B1A7E49; Wed, 24 May 2023 09:04:42 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B8C13617B0; Wed, 24 May 2023 16:04:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B4FE9C4339B; Wed, 24 May 2023 16:04:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1684944242; bh=AvLEpqq/Dfm1IZH9Fj2SEDUypWc1N9U5UTURKsOgFXA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nlzXFI5cSYkrBMMbmjohePIfZJEJ1wyXXh8nVwQWYHkk8no4B3DZgv+dD2ve05da8 pekgyIFhR2BvsiTbttuSUbf8SlIpeOJURyDpYVVmKCeDTjGGj1QtMuuAiz4KNIBzI1 smXEPshQji5C5rb14OqzMaF7TjOIJRvLXVEh+RS0= Date: Wed, 24 May 2023 17:03:59 +0100 From: Greg KH To: Lorenz Bauer Cc: Sasha Levin , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Martin KaFai Lau , ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, shuah@kernel.org, yhs@fb.com, eddyz87@gmail.com, sdf@google.com, error27@gmail.com, iii@linux.ibm.com, memxor@gmail.com, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH AUTOSEL 6.2 08/30] selftests/bpf: check that modifier resolves after pointer Message-ID: <2023052435-xbox-dislike-0ab2@gregkh> References: <20230320005258.1428043-1-sashal@kernel.org> <20230320005258.1428043-8-sashal@kernel.org> <2023041100-oblong-enamel-5893@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, May 24, 2023 at 12:03:43PM +0100, Lorenz Bauer wrote: > On Tue, Apr 11, 2023 at 4:14 PM Greg KH wrote: > > > > I didn't see anything to do here. > > > > And selftests should NOT be broken on stable releases, if so, something > > is wrong as no other subsystem has that happen. > > Sorry for the long delay in replying, I update the kernels we use for > CI only infrequently. Here is an example of the build failure I'm > seeing, from kernel.org 5.10 LTS: > > In file included from > /work/build/5.10.180/tools/testing/selftests/bpf/verifier/tests.h:59, > from test_verifier.c:355: > /work/build/5.10.180/tools/testing/selftests/bpf/verifier/ref_tracking.c:935:3: > error: 'struct bpf_test' has no member named 'fixup_map_ringbuf'; did > you mean 'fixup_map_in_map'? > 935 | .fixup_map_ringbuf = { 11 }, > | ^~~~~~~~~~~~~~~~~ > | fixup_map_in_map > > This is just doing make -C tools/testing/selftests/bpf after compiling a kernel. Great, any specific commits that fix this issue would be appreciated to be pointed at so we can apply them. thanks, greg k-h