From: Greg KH <gregkh@linuxfoundation.org>
To: Wyes Karny <wyes.karny@amd.com>
Cc: stable@vger.kernel.org,
"Gautham R. Shenoy" <gautham.shenoy@amd.com>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>
Subject: Re: [PATCH 6.3.y] cpufreq: amd-pstate: Add ->fast_switch() callback
Date: Thu, 1 Jun 2023 11:22:46 +0100 [thread overview]
Message-ID: <2023060137-mating-bucked-6b32@gregkh> (raw)
In-Reply-To: <20230530115503.3702-1-wyes.karny@amd.com>
On Tue, May 30, 2023 at 11:55:03AM +0000, Wyes Karny wrote:
> From: "Gautham R. Shenoy" <gautham.shenoy@amd.com>
>
> [ Upstream commit 4badf2eb1e986bdbf34dd2f5d4c979553a86fe54 ]
>
> Schedutil normally calls the adjust_perf callback for drivers with
> adjust_perf callback available and fast_switch_possible flag set.
> However, when frequency invariance is disabled and schedutil tries to
> invoke fast_switch. So, there is a chance of kernel crash if this
> function pointer is not set. To protect against this scenario add
> fast_switch callback to amd_pstate driver.
>
> Fixes: 1d215f0319c2 ("cpufreq: amd-pstate: Add fast switch function for AMD P-State")
> Signed-off-by: Gautham R. Shenoy <gautham.shenoy@amd.com>
> Signed-off-by: Wyes Karny <wyes.karny@amd.com>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> (cherry picked from commit 4badf2eb1e986bdbf34dd2f5d4c979553a86fe54)
> ---
> drivers/cpufreq/amd-pstate.c | 37 +++++++++++++++++++++++++++++-------
> 1 file changed, 30 insertions(+), 7 deletions(-)
All now queued up, thanks.
greg k-h
next prev parent reply other threads:[~2023-06-01 10:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-28 16:53 FAILED: patch "[PATCH] cpufreq: amd-pstate: Add ->fast_switch() callback" failed to apply to 6.3-stable tree gregkh
2023-05-30 11:55 ` [PATCH 6.3.y] cpufreq: amd-pstate: Add ->fast_switch() callback Wyes Karny
2023-06-01 10:22 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-05-28 16:54 FAILED: patch "[PATCH] cpufreq: amd-pstate: Update policy->cur in" failed to apply to 6.3-stable tree gregkh
2023-05-30 11:16 ` [PATCH 6.3.y] cpufreq: amd-pstate: Add ->fast_switch() callback Wyes Karny
2023-05-30 11:28 ` Wyes Karny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023060137-mating-bucked-6b32@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=gautham.shenoy@amd.com \
--cc=rafael.j.wysocki@intel.com \
--cc=stable@vger.kernel.org \
--cc=wyes.karny@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox