Missing backport for 04361b8bb818 ("net: sfp: fix state loss when updating state_hw_mask")

Missing backport for 04361b8bb818 ("net: sfp: fix state loss when updating state_hw_mask")

[Andrew Lunn]

Hi Greg, Sasha

Commit 04361b8bb818 ("net: sfp: fix state loss when updating state_hw_mask")

ends with:

    Fixes: 8475c4b70b04 ("net: sfp: re-implement soft state polling setup")

git tag --contains 8475c4b70b04

shows that the problem was introduced in v6.1-rc1. However, the fix
has not been backported yet to v6.1.X

Is the Fixes: tag not sufficient to trigger the machinery to get it
back ported?

Please could you back port it. It cleanly cherry-picks to v6.1.33

Thanks
	Andrew

Re: Missing backport for 04361b8bb818 ("net: sfp: fix state loss when updating state_hw_mask")

[Greg KH]

On Sun, Jun 11, 2023 at 12:37:11AM +0200, Andrew Lunn wrote:
> Hi Greg, Sasha
> 
> Commit 04361b8bb818 ("net: sfp: fix state loss when updating state_hw_mask")
> 
> ends with:
> 
>     Fixes: 8475c4b70b04 ("net: sfp: re-implement soft state polling setup")
> 
> git tag --contains 8475c4b70b04
> 
> shows that the problem was introduced in v6.1-rc1. However, the fix
> has not been backported yet to v6.1.X
> 
> Is the Fixes: tag not sufficient to trigger the machinery to get it
> back ported?

Not at all!  Please see the rules at:
    https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

A "bare" Fixes: tag never guarantees that it will ever go to a stable
tree, you MUST put a cc: stable on it in order to make sure that
happens.

It's been that way for 18+ years now, nothing new :)

> Please could you back port it. It cleanly cherry-picks to v6.1.33

Now queued up, thanks.

greg k-h