From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27941C7EE43 for ; Mon, 12 Jun 2023 10:45:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233132AbjFLKpP (ORCPT ); Mon, 12 Jun 2023 06:45:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48222 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234633AbjFLKoq (ORCPT ); Mon, 12 Jun 2023 06:44:46 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C144AE578 for ; Mon, 12 Jun 2023 03:29:33 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9AFF261372 for ; Mon, 12 Jun 2023 10:29:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8AD28C433EF; Mon, 12 Jun 2023 10:29:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1686565773; bh=JBBUq4gbrULBo0HzY6iuBgY8Jszzi4xcY3pGvuepYDI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZcjhFrVGRz5mpgXH59Sbpk8XSq5beBrc42C5BUZzy2uVad3SlieHM8Bl/UoT6yffZ 6EC4zBqZokaMzMd15FBp5A77pn6mRv4BnFBfCH37PSO4g7fxxwM9IvFmTnBH3oQnCF ADSqheF9G3akUOa4QeSm1I3XgAnwN91ny7bGE2dE= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Hangyu Hua , Larysa Zaremba , "David S. Miller" , Sasha Levin Subject: [PATCH 4.19 10/23] net: sched: fix possible refcount leak in tc_chain_tmplt_add() Date: Mon, 12 Jun 2023 12:26:11 +0200 Message-ID: <20230612101651.506041329@linuxfoundation.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230612101651.138592130@linuxfoundation.org> References: <20230612101651.138592130@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Hangyu Hua [ Upstream commit 44f8baaf230c655c249467ca415b570deca8df77 ] try_module_get will be called in tcf_proto_lookup_ops. So module_put needs to be called to drop the refcount if ops don't implement the required function. Fixes: 9f407f1768d3 ("net: sched: introduce chain templates") Signed-off-by: Hangyu Hua Reviewed-by: Larysa Zaremba Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- net/sched/cls_api.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c index fdd4af137c9fe..6166bbad97536 100644 --- a/net/sched/cls_api.c +++ b/net/sched/cls_api.c @@ -1838,6 +1838,7 @@ static int tc_chain_tmplt_add(struct tcf_chain *chain, struct net *net, return PTR_ERR(ops); if (!ops->tmplt_create || !ops->tmplt_destroy || !ops->tmplt_dump) { NL_SET_ERR_MSG(extack, "Chain templates are not supported with specified classifier"); + module_put(ops->owner); return -EOPNOTSUPP; } -- 2.39.2