From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC357C7EE25 for ; Mon, 12 Jun 2023 10:49:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233373AbjFLKtO (ORCPT ); Mon, 12 Jun 2023 06:49:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54486 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231811AbjFLKsj (ORCPT ); Mon, 12 Jun 2023 06:48:39 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C1B34C1A for ; Mon, 12 Jun 2023 03:33:28 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2B5C861D7A for ; Mon, 12 Jun 2023 10:33:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 39A0EC433EF; Mon, 12 Jun 2023 10:33:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1686566007; bh=YPV71x2wS3X09L4qf53ATcFiN3Hq0JLS9/FDNrrHoZw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KHiQ3lqsv+fakHVE4DzYA6KwKv6mbpE+2/KiibNVsLIfHEKgOaxB16CkFltv+pW0G nKCgb5hNYEjPNHuMxiesGLY8CMB34fOAjYF2SBrE8yLbgXJ61vup3U9SrWxcJnidIA kx4i3QYjUFNRYVP2kpjbKdI0cfOOD4/HEApNtk9E= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Hangyu Hua , Larysa Zaremba , "David S. Miller" , Sasha Levin Subject: [PATCH 5.10 29/68] net: sched: fix possible refcount leak in tc_chain_tmplt_add() Date: Mon, 12 Jun 2023 12:26:21 +0200 Message-ID: <20230612101659.619509110@linuxfoundation.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230612101658.437327280@linuxfoundation.org> References: <20230612101658.437327280@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Hangyu Hua [ Upstream commit 44f8baaf230c655c249467ca415b570deca8df77 ] try_module_get will be called in tcf_proto_lookup_ops. So module_put needs to be called to drop the refcount if ops don't implement the required function. Fixes: 9f407f1768d3 ("net: sched: introduce chain templates") Signed-off-by: Hangyu Hua Reviewed-by: Larysa Zaremba Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- net/sched/cls_api.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c index 16960d9663e9e..befe42aad04ba 100644 --- a/net/sched/cls_api.c +++ b/net/sched/cls_api.c @@ -2772,6 +2772,7 @@ static int tc_chain_tmplt_add(struct tcf_chain *chain, struct net *net, return PTR_ERR(ops); if (!ops->tmplt_create || !ops->tmplt_destroy || !ops->tmplt_dump) { NL_SET_ERR_MSG(extack, "Chain templates are not supported with specified classifier"); + module_put(ops->owner); return -EOPNOTSUPP; } -- 2.39.2