From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6119BC7EE25 for ; Mon, 12 Jun 2023 10:52:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235737AbjFLKwU (ORCPT ); Mon, 12 Jun 2023 06:52:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55552 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234671AbjFLKvy (ORCPT ); Mon, 12 Jun 2023 06:51:54 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B78AC93FB for ; Mon, 12 Jun 2023 03:36:30 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 46A53623E8 for ; Mon, 12 Jun 2023 10:36:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 56AE1C433EF; Mon, 12 Jun 2023 10:36:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1686566189; bh=VNKwHmhtQU8utEFiSXlUXRIv56yC7TqhWyvLidfwrnc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WMXmPZOs4wYKlj5fd9RY+eZZ6gjZ522Rc/tedoxgWCJOu7KxfMyCoGZGVi0bd4CtH 9gXcyBKdvDgXQ/VFHne5aAcd07Ok2D2NbnUXV78zpYv1X/JFV+5CHrRKw0bZ2eQ73Y +jsbh4Gc5D/SN9mkXwQQhfkzRszNq41/I2sQqobs= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Johannes Berg , Sasha Levin Subject: [PATCH 5.15 28/91] wifi: cfg80211: fix locking in regulatory disconnect Date: Mon, 12 Jun 2023 12:26:17 +0200 Message-ID: <20230612101703.279347234@linuxfoundation.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230612101702.085813286@linuxfoundation.org> References: <20230612101702.085813286@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Johannes Berg [ Upstream commit f7e60032c6618dfd643c7210d5cba2789e2de2e2 ] This should use wiphy_lock() now instead of requiring the RTNL, since __cfg80211_leave() via cfg80211_leave() is now requiring that lock to be held. Fixes: a05829a7222e ("cfg80211: avoid holding the RTNL when calling the driver") Signed-off-by: Johannes Berg Signed-off-by: Sasha Levin --- net/wireless/reg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/wireless/reg.c b/net/wireless/reg.c index d0fbe822e7934..0e49264ce1f67 100644 --- a/net/wireless/reg.c +++ b/net/wireless/reg.c @@ -2423,11 +2423,11 @@ static void reg_leave_invalid_chans(struct wiphy *wiphy) struct wireless_dev *wdev; struct cfg80211_registered_device *rdev = wiphy_to_rdev(wiphy); - ASSERT_RTNL(); - + wiphy_lock(wiphy); list_for_each_entry(wdev, &rdev->wiphy.wdev_list, list) if (!reg_wdev_chan_valid(wiphy, wdev)) cfg80211_leave(rdev, wdev); + wiphy_unlock(wiphy); } static void reg_check_chans_work(struct work_struct *work) -- 2.39.2