From: Greg KH <gregkh@linuxfoundation.org>
To: Ilya Dryomov <idryomov@gmail.com>
Cc: stable@vger.kernel.org, Dongsheng Yang <dongsheng.yang@easystack.cn>
Subject: Re: [PATCH for 5.4] rbd: get snapshot context after exclusive lock is ensured to be held
Date: Mon, 12 Jun 2023 11:25:43 +0200 [thread overview]
Message-ID: <2023061228-dab-doorbell-c1ed@gregkh> (raw)
In-Reply-To: <20230611184127.29830-1-idryomov@gmail.com>
On Sun, Jun 11, 2023 at 08:41:27PM +0200, Ilya Dryomov wrote:
> Move capturing the snapshot context into the image request state
> machine, after exclusive lock is ensured to be held for the duration of
> dealing with the image request. This is needed to ensure correctness
> of fast-diff states (OBJECT_EXISTS vs OBJECT_EXISTS_CLEAN) and object
> deltas computed based off of them. Otherwise the object map that is
> forked for the snapshot isn't guaranteed to accurately reflect the
> contents of the snapshot when the snapshot is taken under I/O. This
> breaks differential backup and snapshot-based mirroring use cases with
> fast-diff enabled: since some object deltas may be incomplete, the
> destination image may get corrupted.
>
> Cc: stable@vger.kernel.org
> Link: https://tracker.ceph.com/issues/61472
> Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
> Reviewed-by: Dongsheng Yang <dongsheng.yang@easystack.cn>
> [idryomov@gmail.com: backport to 5.4: no rbd_img_capture_header(),
> img_request not embedded in blk-mq pdu]
> ---
> drivers/block/rbd.c | 41 ++++++++++++++++++++++++-----------------
> 1 file changed, 24 insertions(+), 17 deletions(-)
What is the commit id in Linus's tree of this change?
thanks,
greg k-h
next prev parent reply other threads:[~2023-06-12 9:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-11 18:41 [PATCH for 5.4] rbd: get snapshot context after exclusive lock is ensured to be held Ilya Dryomov
2023-06-12 9:25 ` Greg KH [this message]
2023-06-12 9:32 ` Ilya Dryomov
2023-06-12 9:59 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023061228-dab-doorbell-c1ed@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=dongsheng.yang@easystack.cn \
--cc=idryomov@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox