From: Daniel Thompson <daniel.thompson@linaro.org>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: daniel@ffwll.ch, javierm@redhat.com, sam@ravnborg.org,
deller@gmx.de, geert+renesas@glider.be, lee@kernel.org,
jingoohan1@gmail.com, dan.carpenter@linaro.org,
michael.j.ruhl@intel.com, linux-fbdev@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-sh@vger.kernel.org,
linux-omap@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
Rich Felker <dalias@libc.org>,
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
stable@vger.kernel.org
Subject: Re: [PATCH v2 03/38] backlight/gpio_backlight: Compare against struct fb_info.device
Date: Tue, 13 Jun 2023 11:38:45 +0100 [thread overview]
Message-ID: <20230613103845.GC169438@aspen.lan> (raw)
In-Reply-To: <20230612141352.29939-4-tzimmermann@suse.de>
On Mon, Jun 12, 2023 at 04:07:41PM +0200, Thomas Zimmermann wrote:
> Struct gpio_backlight_platform_data refers to a platform device within
> the Linux device hierarchy. The test in gpio_backlight_check_fb()
> compares it against the fbdev device in struct fb_info.dev, which
> is different. Fix the test by comparing to struct fb_info.device.
>
> Fixes a bug in the backlight driver and prepares fbdev for making
> struct fb_info.dev optional.
>
> v2:
> * move renames into separate patch (Javier, Sam, Michael)
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> Fixes: 8b770e3c9824 ("backlight: Add GPIO-based backlight driver")
> Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Cc: Rich Felker <dalias@libc.org>
> Cc: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
> Cc: Lee Jones <lee@kernel.org>
> Cc: Daniel Thompson <daniel.thompson@linaro.org>
> Cc: Jingoo Han <jingoohan1@gmail.com>
> Cc: linux-sh@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: <stable@vger.kernel.org> # v3.12+
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Daniel.
next prev parent reply other threads:[~2023-06-13 10:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230612141352.29939-1-tzimmermann@suse.de>
2023-06-12 14:07 ` [PATCH v2 01/38] backlight/bd6107: Compare against struct fb_info.device Thomas Zimmermann
2023-06-12 15:00 ` Dan Carpenter
2023-06-12 15:17 ` Ruhl, Michael J
2023-06-13 7:31 ` Thomas Zimmermann
2023-06-13 10:37 ` Daniel Thompson
2023-06-13 10:47 ` Thomas Zimmermann
2023-06-12 14:07 ` [PATCH v2 03/38] backlight/gpio_backlight: " Thomas Zimmermann
2023-06-13 10:38 ` Daniel Thompson [this message]
2023-06-12 14:07 ` [PATCH v2 05/38] backlight/lv5207lp: " Thomas Zimmermann
2023-06-13 10:39 ` Daniel Thompson
2023-06-12 14:07 ` [PATCH v2 14/38] fbdev/ep93xx-fb: Do not assign to struct fb_info.dev Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230613103845.GC169438@aspen.lan \
--to=daniel.thompson@linaro.org \
--cc=dalias@libc.org \
--cc=dan.carpenter@linaro.org \
--cc=daniel@ffwll.ch \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert+renesas@glider.be \
--cc=glaubitz@physik.fu-berlin.de \
--cc=javierm@redhat.com \
--cc=jingoohan1@gmail.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=lee@kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=michael.j.ruhl@intel.com \
--cc=sam@ravnborg.org \
--cc=stable@vger.kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).