From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 1E1C2EB64DC
	for <stable@archiver.kernel.org>; Thu, 15 Jun 2023 05:53:55 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S231366AbjFOFxy (ORCPT <rfc822;stable@archiver.kernel.org>);
        Thu, 15 Jun 2023 01:53:54 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59860 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229677AbjFOFxx (ORCPT
        <rfc822;stable@vger.kernel.org>); Thu, 15 Jun 2023 01:53:53 -0400
Received: from verein.lst.de (verein.lst.de [213.95.11.211])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 18E8410E9;
        Wed, 14 Jun 2023 22:53:52 -0700 (PDT)
Received: by verein.lst.de (Postfix, from userid 2407)
        id 7468067373; Thu, 15 Jun 2023 07:53:49 +0200 (CEST)
Date:   Thu, 15 Jun 2023 07:53:49 +0200
From:   Christoph Hellwig <hch@lst.de>
To:     Michael Schmitz <schmitzmic@gmail.com>
Cc:     Christoph Hellwig <hch@lst.de>, linux-block@vger.kernel.org,
        axboe@kernel.dk, linux-m68k@vger.kernel.org, geert@linux-m68k.org,
        martin@lichtvoll.de, fthain@linux-m68k.org, stable@vger.kernel.org
Subject: Re: [PATCH v10 2/3] block: change annotation of rdb_CylBlocks in
 affs_hardblocks.h
Message-ID: <20230615055349.GA5544@lst.de>
References: <20230615030837.8518-1-schmitzmic@gmail.com> <20230615030837.8518-3-schmitzmic@gmail.com> <20230615041742.GA4426@lst.de> <056834c7-89ca-c8cd-69be-62100f1e5591@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <056834c7-89ca-c8cd-69be-62100f1e5591@gmail.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
Precedence: bulk
List-ID: <stable.vger.kernel.org>
X-Mailing-List: stable@vger.kernel.org

On Thu, Jun 15, 2023 at 04:50:45PM +1200, Michael Schmitz wrote:
>> And as far as I can tell everything that is a __u32 here should
>> be an __be32 because it is a big endian on-disk format.  Why
>> would you change only a single field?
>
> Because that's all I needed, and wanted to avoid excess patch churn. Plus 
> (appeal to authority here :-)) it's in keeping with what Al Viro did when 
> the __be32 annotations were first added.
>
> I can change all __u32 to __be32 and drop the comment if that's preferred.

That would be great!