From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2870AEB64DB for ; Thu, 15 Jun 2023 11:43:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344455AbjFOLnV (ORCPT ); Thu, 15 Jun 2023 07:43:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53518 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344023AbjFOLmn (ORCPT ); Thu, 15 Jun 2023 07:42:43 -0400 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2077.outbound.protection.outlook.com [40.107.22.77]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B019035A2 for ; Thu, 15 Jun 2023 04:39:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AYuyCvMlleB2xbOXdwvqU49YIc+hPfPDjoUD0KMRhOyOJ+VmCITZH0sQxZaTy1T96RgdhYvWvpKx5vAuuZT4NW5zbdRq6eZt8FsQfcbDVDwqMm8wG1tbn+M0aBKqoWLMkkmXMhZiXIVA5ib4O+6ciM4b83P5J8Z8ghYo93PiO2aG3gDrT7w2Ppr8NP5XE4Rj1RxGwg26eslhPy0zg0FRLXgpDXg6th9w6bGVIzI69hkO9DHF8GX+KZ//KTOm3Sp1vRGxDRMVJYDEPBb6fazDZ1HZzoDjupRsEYxIzU9bxIOBNP6KweSW83JKPNFCSdJpKfffDqNvgbW25xjIW7GYAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bTJNdZTXBKoNuFESuzJ9K2gdmmdz0nK6ynG02rGNpPg=; b=VWGIaxyS/Qv48KfMLaYpzwA92RX6Mj6ran1cVmCBR3bfxGuIE9jX7+JjgnEIyRJ29f0DRIdG9f5HiW3v6UAlAg61B9q8ZvWihGFI9YZMR9hjZFJyJZRoVTqz3oxXR4ZMDu1j/+jNi4CHJwto77DClRsE0R0Bi+0UgnwcBv8KIgMTeOTm28/qZeT8dYySdZSU6bfDG3t+/UglsgPwhke5CV+i+XfhbbEGDvtBZ26UVrdBbHAtW7OleleagQZCTtscuFQMrxJA/hin+1XnhJIoyE4hdNz7fWS2MzGg77WAvHhFch2yV0/tWpQUHgT+Jy4AIQZ5nqI5TzI2h7HcTvZufg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 194.138.21.75) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=siemens.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=siemens.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bTJNdZTXBKoNuFESuzJ9K2gdmmdz0nK6ynG02rGNpPg=; b=epGD1uHe0E5KyblU5wYrs4PbJUtHexIRE4htW6b9LaNKJf3KmYRLBxzrxG44zdjSC2d6phXzWdvXpryMtwF7uXQy/3U1VCeCnBSukMRlUmaYUpUDBYrScyfWm6fcc3CTvbMSar9FW6ae80TLHDcslSETAIwULhWGLa9OZFAvf1gHbq/vl49wdSR+6EFbfZ4eeQ6hX1pvGBo4u0dETddhh/BTWA/dldiX2I7KgUq6Z3lWu8rt005P1lZScy8kMEcdcG3Bj9all7kAmSEToyxGN7rAI5SJ+7EsRsTuy7YHD7Cs3vi0rnFQIsNOJLdZzx+gLxBaXEYJ7UICZDntEvQ8zw== Received: from GV3P280CA0014.SWEP280.PROD.OUTLOOK.COM (2603:10a6:150:b::29) by AS2PR10MB7526.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:592::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6477.37; Thu, 15 Jun 2023 11:39:20 +0000 Received: from HE1EUR01FT033.eop-EUR01.prod.protection.outlook.com (2603:10a6:150:b:cafe::76) by GV3P280CA0014.outlook.office365.com (2603:10a6:150:b::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.25 via Frontend Transport; Thu, 15 Jun 2023 11:39:20 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 194.138.21.75) smtp.mailfrom=siemens.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=siemens.com; Received-SPF: Pass (protection.outlook.com: domain of siemens.com designates 194.138.21.75 as permitted sender) receiver=protection.outlook.com; client-ip=194.138.21.75; helo=hybrid.siemens.com; pr=C Received: from hybrid.siemens.com (194.138.21.75) by HE1EUR01FT033.mail.protection.outlook.com (10.152.0.178) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.27 via Frontend Transport; Thu, 15 Jun 2023 11:39:20 +0000 Received: from DEMCHDC8WBA.ad011.siemens.net (139.25.226.105) by DEMCHDC8VRA.ad011.siemens.net (194.138.21.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.25; Thu, 15 Jun 2023 13:39:20 +0200 Received: from md1za8fc.ppmd.siemens.net (139.25.68.220) by DEMCHDC8WBA.ad011.siemens.net (139.25.226.105) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.25; Thu, 15 Jun 2023 13:39:19 +0200 From: Henning Schild To: , Greg Kroah-Hartman CC: , , =?UTF-8?q?Jos=C3=A9=20Roberto=20de=20Souza?= , "Matt Roper" , Henning Schild Subject: [PATCH 5.10 v2 0/2] backport i915 fixes to 5.10 Date: Thu, 15 Jun 2023 13:39:07 +0200 Message-ID: <20230615113909.2109-1-henning.schild@siemens.com> X-Mailer: git-send-email 2.39.3 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [139.25.68.220] X-ClientProxiedBy: DEMCHDC8WBA.ad011.siemens.net (139.25.226.105) To DEMCHDC8WBA.ad011.siemens.net (139.25.226.105) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: HE1EUR01FT033:EE_|AS2PR10MB7526:EE_ X-MS-Office365-Filtering-Correlation-Id: 519d6adf-d421-44af-6606-08db6d9528fd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3PBU+hVikVQGaEa07GPLo9le/hlExGlGRVEznMuqiQ7HtPcyIjZVUa3Qint/sZtxXiPVVqNNPAjggSuec6kRH7AAdCUBnjNeT8LbQqzEcw9johGAetxkwhPF+QeKgO5vc3Wal8DGst7NHE3k2nb+IzHi1hs4H9uv1nGJTuIkK8jUX9wMglikimieb9kr0IzH4YUS1D4po3aC5GpkLzHH2541rfGN7RVEFjidST+/WSx/UtCh6UTnW71k3J+r6oaCRap8++vzk8Xxkmrr8o4DxnDrPE6EWUIVZXRLzyA3aX8Bcb48GU5psEnoc5cSswSJzvHUhwwv9TUE3R25Jr8YL76TvdxQdzxmDBzxsLTFUyfw7juToAsQs4EehhR7lelAjS/yOzsec7r9iueeX+G7y5pXwHw3Lfm9jL1UcQwElMrQB5DUAzZh8IULdXurPhJTMToI0W4MVHQRfAQ9vjOwHADQPN3vvMljXOciRHGXUSGUZWb9/x7WcioSUg19LBxpWYNibO99L1eccxn6Bj4s/dFxCbgmnNNsUi/4JwSW9MpruHUlH5b5RfS8+b5jvbnmlVLPcICYFmArYg4xNvoBGKDfJ52EC/wzCOOVBCvBaOg+5oY/SD0op1gYIEgyCMqGu4Lr/roYV7domzEvB/62lL+acly4u8Gp6LGdqBHPFqEyl3sVn1n3/wlhglcoeqYJa2hVtIdacmXKsTQtMy6i/9rdedHjf7j2HDhPvSf0losDVDeKJOoO4SuVEFu2+WFenB4gagOD5FOccq94Uvp+XQ== X-Forefront-Antispam-Report: CIP:194.138.21.75;CTRY:DE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:hybrid.siemens.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(346002)(39860400002)(396003)(136003)(376002)(451199021)(46966006)(40470700004)(36840700001)(5660300002)(83380400001)(336012)(186003)(40480700001)(44832011)(2906002)(47076005)(16526019)(956004)(2616005)(107886003)(36860700001)(41300700001)(8936002)(26005)(40460700003)(8676002)(316002)(110136005)(54906003)(6666004)(82740400003)(36756003)(478600001)(81166007)(356005)(82310400005)(45080400002)(82960400001)(4326008)(86362001)(70206006)(70586007)(1076003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jun 2023 11:39:20.7213 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 519d6adf-d421-44af-6606-08db6d9528fd X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=38ae3bcd-9579-4fd4-adda-b42e1495d55a;Ip=[194.138.21.75];Helo=[hybrid.siemens.com] X-MS-Exchange-CrossTenant-AuthSource: HE1EUR01FT033.eop-EUR01.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR10MB7526 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org changes since v1: - added my Signed-Offs - removed additional "From"s - change cover letter to motivate need for patch1 This fixes the following problem which was seen on a Tigerlake running Debian 10 with a 5.10 kernel. The fix is in the second patch while the first patch just makes sure the latter one does apply. [ 111.408631] Missing case (val == 65535) [ 111.408698] WARNING: CPU: 2 PID: 446 at drivers/gpu/drm/i915/intel_dram.c:95 skl_dram_get_dimm_info+0x72/0x1a0 [i915] [ 111.408699] Modules linked in: intel_powerclamp coretemp i915(+) joydev kvm_intel kvm hid_generic irqbypass crc32_pclmul snd_hda_intel ghash_clmulni_intel snd_intel_dspcfg snd_hda_codec aesni_intel glue_helper crypto_simd cryptd snd_hwdep snd_hda_core drm_kms_helper uas snd_pcm usb_storage intel_cstate mei_wdt mei_hdcp snd_timer scsi_mod usbhid hid cec wdat_wdt snd mei_me evdev mei intel_uncore rc_core watchdog pcspkr soundcore video acpi_pad acpi_tad button drm fuse configfs loop(+) efi_pstore efivarfs ip_tables x_tables autofs4 ext4 crc32c_generic crc16 mbcache jbd2 dm_mod xhci_pci xhci_hcd marvell dwmac_intel stmmac igb e1000e usbcore nvme nvme_core pcs_xpcs phylink libphy i2c_algo_bit t10_pi dca crc_t10dif crct10dif_generic intel_lpss_pci ptp vmd intel_lpss i2c_i801 crct10dif_pclmul pps_core crct10dif_common idma64 usb_common crc32c_intel i2c_smbus [ 111.408755] CPU: 2 PID: 446 Comm: (udev-worker) Not tainted 5.10.180 #2 [ 111.408756] Hardware name: SIEMENS AG SIMATIC IPC427G/no information, BIOS T29.01.02.D3.0 10/11/2022 [ 111.408797] RIP: 0010:skl_dram_get_dimm_info+0x72/0x1a0 [i915] [ 111.408799] Code: 01 00 00 0f 84 31 01 00 00 66 3d 00 01 0f 84 27 01 00 00 41 0f b7 d0 48 c7 c6 ba 81 7c c1 48 c7 c7 be 81 7c c1 e8 d2 75 89 fa <0f> 0b c6 45 01 00 44 0f b6 4d 00 31 f6 b9 01 00 00 00 c1 fb 09 83 [ 111.408801] RSP: 0018:ffffa23a40b53b10 EFLAGS: 00010286 [ 111.408802] RAX: 0000000000000000 RBX: 000000000000ffff RCX: 0000000000000027 [ 111.408803] RDX: ffff947b278a0908 RSI: 0000000000000001 RDI: ffff947b278a0900 [ 111.408804] RBP: ffffa23a40b53b78 R08: 0000000000000000 R09: ffffa23a40b53920 [ 111.408805] R10: ffffa23a40b53918 R11: 0000000000000003 R12: 0000000000000000 [ 111.408806] R13: 000000000000004c R14: ffff9479b1a00000 R15: ffff9479b1a00000 [ 111.408808] FS: 00007ff9626478c0(0000) GS:ffff947b27880000(0000) knlGS:0000000000000000 [ 111.408809] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 111.408810] CR2: 0000555753cbf15c CR3: 0000000108432002 CR4: 0000000000770ee0 [ 111.408810] PKRU: 55555554 [ 111.408811] Call Trace: [ 111.408854] skl_dram_get_channel_info+0x24/0x160 [i915] [ 111.408892] intel_dram_detect+0xef/0x630 [i915] [ 111.408931] i915_driver_probe+0xb18/0xc40 [i915] [ 111.408969] ? i915_pci_probe+0x3f/0x160 [i915] [ 111.408973] local_pci_probe+0x3b/0x80 [ 111.408975] pci_device_probe+0xfc/0x1b0 [ 111.408979] really_probe+0x26e/0x460 [ 111.408981] driver_probe_device+0xb4/0x100 [ 111.408983] device_driver_attach+0xa9/0xb0 [ 111.408984] ? device_driver_attach+0xb0/0xb0 [ 111.408985] __driver_attach+0xa1/0x140 [ 111.408987] ? device_driver_attach+0xb0/0xb0 [ 111.408989] bus_for_each_dev+0x84/0xd0 [ 111.408991] bus_add_driver+0x13e/0x200 [ 111.408993] driver_register+0x89/0xe0 [ 111.409036] i915_init+0x60/0x75 [i915] [ 111.409038] ? 0xffffffffc18b8000 [ 111.409041] do_one_initcall+0x56/0x1f0 [ 111.409044] do_init_module+0x4a/0x240 [ 111.409047] __do_sys_finit_module+0xaa/0x110 [ 111.409050] do_syscall_64+0x30/0x40 [ 111.409053] entry_SYSCALL_64_after_hwframe+0x61/0xc6 [ 111.409054] RIP: 0033:0x7ff962d534f9 [ 111.409056] Code: 08 89 e8 5b 5d c3 66 2e 0f 1f 84 00 00 00 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d d7 08 0d 00 f7 d8 64 89 01 48 [ 111.409057] RSP: 002b:00007fff57caf5d8 EFLAGS: 00000246 ORIG_RAX: 0000000000000139 [ 111.409058] RAX: ffffffffffffffda RBX: 0000555753cad120 RCX: 00007ff962d534f9 [ 111.409059] RDX: 0000000000000000 RSI: 00007ff962ee6efd RDI: 0000000000000010 [ 111.409060] RBP: 00007ff962ee6efd R08: 0000000000000000 R09: 0000555753c7a320 [ 111.409061] R10: 0000000000000010 R11: 0000000000000246 R12: 0000000000020000 [ 111.409062] R13: 0000000000000000 R14: 0000555753ca4f30 R15: 0000555752d40e4f [ 111.409064] ---[ end trace 2da6ec0bd6f7c3a1 ]--- José Roberto de Souza (1): drm/i915/gen11+: Only load DRAM information from pcode Matt Roper (1): drm/i915/dg1: Wait for pcode/uncore handshake at startup drivers/gpu/drm/i915/display/intel_bw.c | 80 +++--------------------- drivers/gpu/drm/i915/i915_drv.c | 4 ++ drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/i915_reg.h | 3 + drivers/gpu/drm/i915/intel_dram.c | 82 ++++++++++++++++++++++++- drivers/gpu/drm/i915/intel_sideband.c | 15 +++++ drivers/gpu/drm/i915/intel_sideband.h | 2 + 7 files changed, 114 insertions(+), 73 deletions(-) -- 2.39.3