From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Jim Wylder <jwylder@google.com>, Sasha Levin <sashal@kernel.org>,
broonie@kernel.org, gregkh@linuxfoundation.org
Subject: [PATCH AUTOSEL 5.10 1/9] regmap: Account for register length when chunking
Date: Thu, 15 Jun 2023 07:39:09 -0400 [thread overview]
Message-ID: <20230615113917.649505-1-sashal@kernel.org> (raw)
From: Jim Wylder <jwylder@google.com>
[ Upstream commit 3981514180c987a79ea98f0ae06a7cbf58a9ac0f ]
Currently, when regmap_raw_write() splits the data, it uses the
max_raw_write value defined for the bus. For any bus that includes
the target register address in the max_raw_write value, the chunked
transmission will always exceed the maximum transmission length.
To avoid this problem, subtract the length of the register and the
padding from the maximum transmission.
Signed-off-by: Jim Wylder <jwylder@google.com
Link: https://lore.kernel.org/r/20230517152444.3690870-2-jwylder@google.com
Signed-off-by: Mark Brown <broonie@kernel.org
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
drivers/base/regmap/regmap.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c
index 55a30afc14a00..2a3c3dfefdcec 100644
--- a/drivers/base/regmap/regmap.c
+++ b/drivers/base/regmap/regmap.c
@@ -1998,6 +1998,8 @@ int _regmap_raw_write(struct regmap *map, unsigned int reg,
size_t val_count = val_len / val_bytes;
size_t chunk_count, chunk_bytes;
size_t chunk_regs = val_count;
+ size_t max_data = map->max_raw_write - map->format.reg_bytes -
+ map->format.pad_bytes;
int ret, i;
if (!val_count)
@@ -2005,8 +2007,8 @@ int _regmap_raw_write(struct regmap *map, unsigned int reg,
if (map->use_single_write)
chunk_regs = 1;
- else if (map->max_raw_write && val_len > map->max_raw_write)
- chunk_regs = map->max_raw_write / val_bytes;
+ else if (map->max_raw_write && val_len > max_data)
+ chunk_regs = max_data / val_bytes;
chunk_count = val_count / chunk_regs;
chunk_bytes = chunk_regs * val_bytes;
--
2.39.2
next reply other threads:[~2023-06-15 11:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-15 11:39 Sasha Levin [this message]
2023-06-15 11:39 ` [PATCH AUTOSEL 5.10 2/9] scsi: target: iscsi: Prevent login threads from racing between each other Sasha Levin
2023-06-15 11:39 ` [PATCH AUTOSEL 5.10 3/9] HID: google: add jewel USB id Sasha Levin
2023-06-15 11:39 ` [PATCH AUTOSEL 5.10 4/9] HID: wacom: Add error check to wacom_parse_and_register() Sasha Levin
2023-06-15 11:39 ` [PATCH AUTOSEL 5.10 5/9] arm64: Add missing Set/Way CMO encodings Sasha Levin
2023-06-15 11:39 ` [PATCH AUTOSEL 5.10 6/9] media: cec: core: don't set last_initiator if tx in progress Sasha Levin
2023-06-15 11:39 ` [PATCH AUTOSEL 5.10 7/9] nfcsim.c: Fix error checking for debugfs_create_dir Sasha Levin
2023-06-15 11:39 ` [PATCH AUTOSEL 5.10 8/9] usb: gadget: udc: fix NULL dereference in remove() Sasha Levin
2023-06-15 11:39 ` [PATCH AUTOSEL 5.10 9/9] ext4: enable the lazy init thread when remounting read/write Sasha Levin
2023-06-16 19:41 ` Pavel Machek
2023-06-20 14:43 ` Sasha Levin
2023-06-20 22:25 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230615113917.649505-1-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jwylder@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).