From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A9EDEB64D8 for ; Fri, 16 Jun 2023 10:37:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345309AbjFPKh2 (ORCPT ); Fri, 16 Jun 2023 06:37:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345455AbjFPKfB (ORCPT ); Fri, 16 Jun 2023 06:35:01 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 939615BBF; Fri, 16 Jun 2023 03:29:10 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D16B8636CF; Fri, 16 Jun 2023 10:28:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 92C01C433CB; Fri, 16 Jun 2023 10:28:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686911298; bh=o57FQvm2+7yG6jHoyGOwjcTQiG9Ut7wL1viELa5UJwM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bLUfg4fAg/EIDOF2RtTDiCOMRi2i459wBq4+QAhjxLMVIOYjgzFUoakQ5ftoCnOwC EmryX+YtDyQl0niA6NzOXpkbKKvPju+pzyzGTyJBEkLV8qrsh7jUtgKlmqDc2PRiqS TCCIuOO+FFpGf6WwG03/5vNPG/WzA/JM+5YdGwyFHpSB3XjK7Lzl2hfQG2MSdUEbMd BOzrGI78Kmj1dym5cBG4Z+2T0nDvGuY9CBDK0VkKizFzatRBCtsDwEx2NeZwasLEOD 4oRVgXtD46o+Sf6hE96rXjHxjPyqEJLxlCLEI2OZsU2OYWCS/S7m61tfFZTN/8oTNz uIkF1l/FIltSA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Theodore Ts'o , Sasha Levin , adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org Subject: [PATCH AUTOSEL 5.10 12/14] Revert "ext4: don't clear SB_RDONLY when remounting r/w until quota is re-enabled" Date: Fri, 16 Jun 2023 06:27:49 -0400 Message-Id: <20230616102753.673975-12-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230616102753.673975-1-sashal@kernel.org> References: <20230616102753.673975-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.10.184 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Theodore Ts'o [ Upstream commit 1b29243933098cdbc31b579b5616e183b4275e2f ] This reverts commit a44be64bbecb15a452496f60db6eacfee2b59c79. Link: https://lore.kernel.org/r/653b3359-2005-21b1-039d-c55ca4cffdcc@gmail.com Signed-off-by: Theodore Ts'o Signed-off-by: Sasha Levin --- fs/ext4/super.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/fs/ext4/super.c b/fs/ext4/super.c index f72896384dbc9..84b4fc9833e38 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -5799,7 +5799,6 @@ static int ext4_remount(struct super_block *sb, int *flags, char *data) ext4_group_t g; unsigned int journal_ioprio = DEFAULT_JOURNAL_IOPRIO; int err = 0; - int enable_rw = 0; #ifdef CONFIG_QUOTA int enable_quota = 0; int i, j; @@ -5992,7 +5991,7 @@ static int ext4_remount(struct super_block *sb, int *flags, char *data) if (err) goto restore_opts; - enable_rw = 1; + sb->s_flags &= ~SB_RDONLY; if (ext4_has_feature_mmp(sb)) { err = ext4_multi_mount_protect(sb, le64_to_cpu(es->s_mmp_block)); @@ -6039,9 +6038,6 @@ static int ext4_remount(struct super_block *sb, int *flags, char *data) if (!test_opt(sb, BLOCK_VALIDITY) && sbi->s_system_blks) ext4_release_system_zone(sb); - if (enable_rw) - sb->s_flags &= ~SB_RDONLY; - /* * Reinitialize lazy itable initialization thread based on * current settings -- 2.39.2