From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCAF9EB64D8 for ; Fri, 16 Jun 2023 10:37:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345336AbjFPKhe (ORCPT ); Fri, 16 Jun 2023 06:37:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56672 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345635AbjFPKfu (ORCPT ); Fri, 16 Jun 2023 06:35:50 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C1BC49D9; Fri, 16 Jun 2023 03:29:33 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 11090636E9; Fri, 16 Jun 2023 10:28:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2CA9DC433C8; Fri, 16 Jun 2023 10:28:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686911336; bh=VQwq2GGlOeLSqeUbYh++6YIJ1yOtsEnLMmu1TMUlSKc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=W+ZhJv+YvggHLQX9h9CYl/1UIoVFvHwqjcfm6do2ZhnTvJGxxBqAWCuYPqeZsCcRs f0Sf2lvkZh5I0oEuD1IS+2Q3unHocFOY8B4lSv7cbBMRLkdUq56HMqsz/UtZUnf8YO 4pOZ04PJm+2VUiOB+4ns1qU+0SPw2+dgyToqFfRPll/+VWZrjPFcY3rtjnCECU9CKL fCj4lp7vPZCM7SEjwBDl6W7cIL18/bJWAn9UmsyX4LX3dPV9UuLxLHF2T07zNtSZQa JCq7TNq9Qshsj4ihddY5zLqBbsKimFhhljkEe3H5UyFZnTWxiNQvi0FS+uCGk6MjoO rOxI+V7MXAlCw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Inki Dae , Andi Shyti , Sasha Levin , sw0312.kim@samsung.com, kyungmin.park@samsung.com, airlied@gmail.com, daniel@ffwll.ch, krzysztof.kozlowski@linaro.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 2/5] drm/exynos: vidi: fix a wrong error return Date: Fri, 16 Jun 2023 06:28:48 -0400 Message-Id: <20230616102852.674366-2-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230616102852.674366-1-sashal@kernel.org> References: <20230616102852.674366-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 4.14.318 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Inki Dae [ Upstream commit 4a059559809fd1ddbf16f847c4d2237309c08edf ] Fix a wrong error return by dropping an error return. When vidi driver is remvoed, if ctx->raw_edid isn't same as fake_edid_info then only what we have to is to free ctx->raw_edid so that driver removing can work correctly - it's not an error case. Signed-off-by: Inki Dae Reviewed-by: Andi Shyti Signed-off-by: Sasha Levin --- drivers/gpu/drm/exynos/exynos_drm_vidi.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_vidi.c b/drivers/gpu/drm/exynos/exynos_drm_vidi.c index 53e03f8af3d5e..f36d4df4d481d 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_vidi.c +++ b/drivers/gpu/drm/exynos/exynos_drm_vidi.c @@ -480,8 +480,6 @@ static int vidi_remove(struct platform_device *pdev) if (ctx->raw_edid != (struct edid *)fake_edid_info) { kfree(ctx->raw_edid); ctx->raw_edid = NULL; - - return -EINVAL; } component_del(&pdev->dev, &vidi_component_ops); -- 2.39.2