Re: [PATCH 1/2] usb: gadget: f_ncm: Add OS descriptor support

["gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>]

On Sun, Jun 18, 2023 at 11:42:59AM +0000, Joakim Tjernlund wrote:
> On Sun, 2023-06-18 at 13:04 +0200, gregkh@linuxfoundation.org wrote:
> > On Sun, Jun 18, 2023 at 09:58:14AM +0000, Joakim Tjernlund wrote:
> > > On Sun, 2023-06-18 at 09:36 +0200, Greg KH wrote:
> > > > On Sat, Jun 17, 2023 at 04:03:06PM +0000, Joakim Tjernlund wrote:
> > > > > Ping ?
> > > > > 
> > > > > Did I do something wrong with submission or is it queued for later ?
> > > > > 4.19 is missing these which make USB NCM unusable with Win >= 10. 
> > > > > 
> > > > >  Jocke
> > > > > 
> > > > > On Wed, 2023-05-31 at 19:33 +0200, Joakim Tjernlund wrote:
> > > > > > From: Romain Izard <romain.izard.pro@gmail.com>
> > > > > > 
> > > > > > To be able to use the default USB class drivers available in Microsoft
> > > > > > Windows, we need to add OS descriptors to the exported USB gadget to
> > > > > > tell the OS that we are compatible with the built-in drivers.
> > > > > > 
> > > > > > Copy the OS descriptor support from f_rndis into f_ncm. As a result,
> > > > > > using the WINNCM compatible ID, the UsbNcm driver is loaded on
> > > > > > enumeration without the need for a custom driver or inf file.
> > > > > > 
> > > > > > Signed-off-by: Romain Izard <romain.izard.pro@gmail.com>
> > > > > > Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
> > > > > > Signed-off-by: Joakim Tjernlund <joakim.tjernlund@infinera.com>
> > > > > > Cc: stable@vger.kernel.org # v4.19
> > > > > > ---
> > > > > > 
> > > > > >  Seems to have been forgotten when backporting NCM fixes.
> > > > > >  Needed to make Win10 accept Linux NCM gadget ethernet
> > > > > > 
> > > > > >  drivers/usb/gadget/function/f_ncm.c | 47 +++++++++++++++++++++++++++--
> > > > > >  drivers/usb/gadget/function/u_ncm.h |  3 ++
> > > > > >  2 files changed, 47 insertions(+), 3 deletions(-)
> > > > 
> > > > What is the git commit id of this change in Linus's tree?
> > > > 
> > > > thanks,
> > > > 
> > > > greg k-h
> > > For this patch:
> > > 	793409292382027226769d0299987f06cbd97a6e
> > > 
> > > and for "usb: gadget: f_ncm: Fix NTP-32 support"
> > > 	550eef0c353030ac4223b9c9479bdf77a05445d6
> > 
> > Ah, yeah, they did get lost in the deluge, sorry.
> > 
> > Can you please resend these _with_ the git commit id in the message so
> > that we know what is going on?
> > 
> > thanks,
> > 
> > greg k-h
> 
> Resent as PATCHv2 with commit id's

Both now queued up, thanks.

greg k-h