From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C9BFEB64DA for ; Mon, 19 Jun 2023 10:52:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232076AbjFSKv7 (ORCPT ); Mon, 19 Jun 2023 06:51:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52000 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230375AbjFSKvZ (ORCPT ); Mon, 19 Jun 2023 06:51:25 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 27BB21FDF for ; Mon, 19 Jun 2023 03:50:46 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6E9C160B82 for ; Mon, 19 Jun 2023 10:50:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7FBC6C433C0; Mon, 19 Jun 2023 10:50:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1687171844; bh=GBjQILzGthxWzniGtG0dxUB6FGhTts3BxR2bIVnnOkQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JjArf2kyya4HCO88Tz5/HXwY/ZPlur1u/B1G4I8EQsucwgJwjQ3c61pm5zJ+4l86Y kHFGCr4wXvZv7j3dGjCTy0i8w218q/L3843R70bOGQzIlTsJHCNKU2pmIy4nWmSjx1 HvL2co67Sb8CRAy46ydHFmDnmLn3msxpdJv3rD5g= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Sasha Levin Subject: [PATCH 5.4 11/64] regulator: Fix error checking for debugfs_create_dir Date: Mon, 19 Jun 2023 12:30:07 +0200 Message-ID: <20230619102133.408720279@linuxfoundation.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230619102132.808972458@linuxfoundation.org> References: <20230619102132.808972458@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Osama Muhammad [ Upstream commit 2bf1c45be3b8f3a3f898d0756c1282f09719debd ] This patch fixes the error checking in core.c in debugfs_create_dir. The correct way to check if an error occurred is 'IS_ERR' inline function. Signed-off-by: Osama Muhammad --- drivers/regulator/core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index 06da271ad5dd3..cc9aa95d69691 100644 --- a/drivers/regulator/core.c +++ b/drivers/regulator/core.c @@ -4906,7 +4906,7 @@ static void rdev_init_debugfs(struct regulator_dev *rdev) } rdev->debugfs = debugfs_create_dir(rname, debugfs_root); - if (!rdev->debugfs) { + if (IS_ERR(rdev->debugfs)) { rdev_warn(rdev, "Failed to create debugfs directory\n"); return; } @@ -5796,7 +5796,7 @@ static int __init regulator_init(void) ret = class_register(®ulator_class); debugfs_root = debugfs_create_dir("regulator", NULL); - if (!debugfs_root) + if (IS_ERR(debugfs_root)) pr_warn("regulator: Failed to create debugfs directory\n"); #ifdef CONFIG_DEBUG_FS -- 2.39.2