From: Greg KH <gregkh@linuxfoundation.org>
To: Matthieu Baerts <matthieu.baerts@tessares.net>
Cc: kuba@kernel.org, stable@vger.kernel.org
Subject: Re: FAILED: patch "[PATCH] selftests: mptcp: pm nl: remove hardcoded default limits" failed to apply to 5.4-stable tree
Date: Thu, 22 Jun 2023 19:06:10 +0200 [thread overview]
Message-ID: <2023062249-frisbee-omen-5757@gregkh> (raw)
In-Reply-To: <36b7e220-3f9f-726d-62d7-af05eededeab@tessares.net>
On Thu, Jun 22, 2023 at 03:38:45PM +0200, Matthieu Baerts wrote:
> Hi Greg,
>
> On 22/06/2023 09:57, gregkh@linuxfoundation.org wrote:
> >
> > The patch below does not apply to the 5.4-stable tree.
> > If someone wants it applied there, or to any other stable or longterm
> > tree, then please email the backport, including the original git commit
> > id to <stable@vger.kernel.org>.
> >
> > To reproduce the conflict and resubmit, you may use the following commands:
>
> (...)
>
> > ------------------ original commit in Linus's tree ------------------
> >
> > From 2177d0b08e421971e035672b70f3228d9485c650 Mon Sep 17 00:00:00 2001
> > From: Matthieu Baerts <matthieu.baerts@tessares.net>
> > Date: Thu, 8 Jun 2023 18:38:49 +0200
> > Subject: [PATCH] selftests: mptcp: pm nl: remove hardcoded default limits
> >
> > Selftests are supposed to run on any kernels, including the old ones not
> > supporting all MPTCP features.
> >
> > One of them is the checks of the default limits returned by the MPTCP
> > in-kernel path-manager. The default values have been modified by commit
> > 72bcbc46a5c3 ("mptcp: increase default max additional subflows to 2").
> > Instead of comparing with hardcoded values, we can get the default one
> > and compare with them.
> >
> > Note that if we expect to have the latest version, we continue to check
> > the hardcoded values to avoid unexpected behaviour changes.
> >
> > Link: https://github.com/multipath-tcp/mptcp_net-next/issues/368
> > Fixes: eedbc685321b ("selftests: add PM netlink functional tests")
>
> Thank you for this notification!
>
> I'm not sure why this patch got picked up for v5.4-stable tree because
> it is fixing code that is not in v5.4 but introduced in v5.7. The commit
> mentioned here above has not been backported in v5.4. That seems to be
> confirmed by:
>
> https://kernel.dance/#eedbc685321b
>
> So no need to do anything here.
Yes, my fault, I sent out too many "this failed" messages for some of
these, sorry about that.
greg k-h
prev parent reply other threads:[~2023-06-22 17:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-22 7:57 FAILED: patch "[PATCH] selftests: mptcp: pm nl: remove hardcoded default limits" failed to apply to 5.4-stable tree gregkh
2023-06-22 13:38 ` Matthieu Baerts
2023-06-22 17:06 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023062249-frisbee-omen-5757@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=kuba@kernel.org \
--cc=matthieu.baerts@tessares.net \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox