From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D372EB64DC for ; Mon, 26 Jun 2023 20:47:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230284AbjFZUr1 (ORCPT ); Mon, 26 Jun 2023 16:47:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46432 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229720AbjFZUr0 (ORCPT ); Mon, 26 Jun 2023 16:47:26 -0400 Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9514A139 for ; Mon, 26 Jun 2023 13:47:24 -0700 (PDT) Received: by mail-pl1-x633.google.com with SMTP id d9443c01a7336-1b51488ad67so19056505ad.3 for ; Mon, 26 Jun 2023 13:47:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1687812444; x=1690404444; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=Kms0H0qh0BC4E2qqH9Z2kg6XISwIpNu68Rt88k6ZU9Q=; b=b6tD4vEHA9gzY35UuB/3ZPY6VXg3JK4i/zJQpSmzcyjmImYw3S3AZxmuC/LO7qrRHL 0OPNSnECNq6rI1m+NTfcw5y4T4yOBrqbj14pLGLE6W/zhm7plrIW8tUujSR4hcynV1oy P27X5sd+Hc+Q25xcY/jY5XFyFA+6UBpUcLgqxaSBEEv4BCXrxzK7Omy2zHpQzEc/DjPR 13neo9pSlKT+sV1tPjVkBlICkU85jivaG3EsWDBtcI4FxNBTSYwk2uMDzZdEYlvtSu6a NWv0o8xHVXOk9+J+HhT60qemCSboEreLuD/mxA2KGBfXxNMoI6L4H9hGxULcqImpM8Dy 1qcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687812444; x=1690404444; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Kms0H0qh0BC4E2qqH9Z2kg6XISwIpNu68Rt88k6ZU9Q=; b=O/FXd4qQwTP1FPwbCGINP2TH0Xd6VH6eahDlAPjFuBah2qQ+xahfU+6easW6PDtjvg WOSmxOZzXDQ8oEXvlOEYrGvCTdQc9mMw1qzXujHGpjLNFPU4s5k+lHO4gGEfl6KXombV C28TALgKEGbsBYnOvwP9sq97FOfmqKfGxTCb1IhsJJ9v2sMGN/nuCwHXlcyeMDkkNszv FAZbVWDiGHimS21jMAAqa/u00YVFhLqchXGVJf11YysQqrAfAr9MxLcO9XxpsaOqtn5E kZExirhnmml8LfnZPYMchzQLobZbIIeP9QVYC+itvM9yH88TXIoe7CUSLX2B2Bx2Fj1X SuSg== X-Gm-Message-State: AC+VfDxC5F5hPhLpQIEic3n080pEeQu2UlU/WakLvbEwzmLN2G3lSs+a GBc4CqakJM5JNQuAMnSzElTZyw== X-Google-Smtp-Source: ACHHUZ5fzWr4Vm6bBdKDmKxsox3wJmLPjxaF521aPRnVQeoeej/eMt9HBi1dHHVHz+Pmx4dFCv82Ug== X-Received: by 2002:a17:902:c085:b0:1b6:a972:4414 with SMTP id j5-20020a170902c08500b001b6a9724414mr4558982pld.3.1687812444029; Mon, 26 Jun 2023 13:47:24 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id k19-20020a170902ba9300b001ab39cd875csm4594066pls.133.2023.06.26.13.47.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jun 2023 13:47:23 -0700 (PDT) Date: Mon, 26 Jun 2023 13:47:21 -0700 From: Stephen Hemminger To: Dexuan Cui Cc: Simon Horman , souradeep chakrabarti , KY Srinivasan , Haiyang Zhang , "wei.liu@kernel.org" , "davem@davemloft.net" , "edumazet@google.com" , "kuba@kernel.org" , "pabeni@redhat.com" , Long Li , Ajay Sharma , "leon@kernel.org" , "cai.huoqing@linux.dev" , "ssengar@linux.microsoft.com" , "vkuznets@redhat.com" , "tglx@linutronix.de" , "linux-hyperv@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-rdma@vger.kernel.org" , "stable@vger.kernel.org" , Souradeep Chakrabarti Subject: Re: [PATCH 1/2 V3 net] net: mana: Fix MANA VF unload when host is unresponsive Message-ID: <20230626134721.256c6c16@hermes.local> In-Reply-To: References: <1687771058-26634-1-git-send-email-schakrabarti@linux.microsoft.com> <1687771098-26775-1-git-send-email-schakrabarti@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Mon, 26 Jun 2023 20:06:48 +0000 Dexuan Cui wrote: > > From: Simon Horman > > Sent: Monday, June 26, 2023 6:05 AM > > > ... > > > Fixes: ca9c54d2d6a5ab2430c4eda364c77125d62e5e0f (net: mana: Add a > > > driver for > > > Microsoft Azure Network Adapter) > > > > nit: A correct format of this fixes tag is: > > > > In particular: > > * All on lone line > > * Description in double quotes. > > > > Fixes: ca9c54d2d6a5 ("net: mana: Add a driver for Microsoft Azure Network > > Adapter (MANA)") > > Hi Souradeep, FYI I often refer to: > https://marc.info/?l=linux-pci&m=150905742808166&w=2 > > The link mentions: > alias gsr='git --no-pager show -s --abbrev-commit --abbrev=12 --pretty=format:"%h (\"%s\")%n"' > > "gsr ca9c54d2d6a5ab2430c4eda364c77125d62e5e0f" produces: > ca9c54d2d6a5 ("net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)") You can do same thing without shell alias by using git-config [alias] fixes = log -1 --format=fixes gsr = log -1 --format=gsr [pretty] fixes = Fixes: %h (\"%s\") gsr = %h (\"%s\") Then: $ git gsr 1919b39fc6eabb9a6f9a51706ff6d03865f5df29 1919b39fc6ea ("net: mana: Fix perf regression: remove rx_cqes, tx_cqes counters")