From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14221EB64D7 for ; Mon, 26 Jun 2023 18:25:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232036AbjFZSZR (ORCPT ); Mon, 26 Jun 2023 14:25:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231980AbjFZSYt (ORCPT ); Mon, 26 Jun 2023 14:24:49 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 42F9D10CC for ; Mon, 26 Jun 2023 11:24:18 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4B39560E76 for ; Mon, 26 Jun 2023 18:24:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 56606C433C9; Mon, 26 Jun 2023 18:24:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1687803844; bh=neA9qgU3dCAsv5QE8daUZ122pqBqvw9cm8lilPq1gEk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UuUA6Xe7sdgQmsoTLkDexaGBvFwgv1qhyOCt1Yev3OhkFrMuPO741STlX25u6xNgf Oz2s8KSlIvGoc7fqTasPbGX8v4TD26J9OkZSN8UoVxcwJN9KxMNrcgG0QZX3WZmJUy 5nG76RaWdD8fSNx/hMstKrGvP8RaQ98wQP5Qo4I0= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Coverity Scan , Namjae Jeon , Steve French Subject: [PATCH 6.3 197/199] ksmbd: fix uninitialized pointer read in ksmbd_vfs_rename() Date: Mon, 26 Jun 2023 20:11:43 +0200 Message-ID: <20230626180814.377177329@linuxfoundation.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230626180805.643662628@linuxfoundation.org> References: <20230626180805.643662628@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Namjae Jeon commit 48b47f0caaa8a9f05ed803cb4f335fa3a7bfc622 upstream. Uninitialized rd.delegated_inode can be used in vfs_rename(). Fix this by setting rd.delegated_inode to NULL to avoid the uninitialized read. Fixes: 74d7970febf7 ("ksmbd: fix racy issue from using ->d_parent and ->d_name") Reported-by: Coverity Scan Signed-off-by: Namjae Jeon Signed-off-by: Steve French Signed-off-by: Greg Kroah-Hartman --- fs/ksmbd/vfs.c | 1 + 1 file changed, 1 insertion(+) --- a/fs/ksmbd/vfs.c +++ b/fs/ksmbd/vfs.c @@ -769,6 +769,7 @@ retry: rd.new_dir = new_path.dentry->d_inode, rd.new_dentry = new_dentry, rd.flags = flags, + rd.delegated_inode = NULL, err = vfs_rename(&rd); if (err) ksmbd_debug(VFS, "vfs_rename failed err %d\n", err);