From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2736EB64DC for ; Thu, 29 Jun 2023 15:29:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232328AbjF2P3W (ORCPT ); Thu, 29 Jun 2023 11:29:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54192 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232351AbjF2P3T (ORCPT ); Thu, 29 Jun 2023 11:29:19 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 79A4B30F0 for ; Thu, 29 Jun 2023 08:29:08 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F2BB761575 for ; Thu, 29 Jun 2023 15:29:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 75670C433C8; Thu, 29 Jun 2023 15:29:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1688052547; bh=2Uvy2UbuCzcaUp0rfvGnKqPN5KswhX7RTrKtXr0QeSc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lRBOaZxC/P8oenpZWxqXxGrwblCUGqMd0B2355gGdCqUPNZFh/dml61fweJFkILEz 3IIbDaxrCraCd/LOX3w/pyAYCktDnkpchMbVySl+Q9cU3jD0uEEngWsLoweSBhP1UL S9nasbQKhKHSL6sySLfQEfnYRWHXS4CuqrwSU/1w= Date: Thu, 29 Jun 2023 17:29:03 +0200 From: Greg Kroah-Hartman To: Helge Deller Cc: stable@vger.kernel.org, Sasha Levin Subject: Re: [PATCH][for-4.14] fbdev: imsttfb: Fix use after free bug in imsttfb_probe Message-ID: <2023062948-deface-banker-462d@gregkh> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Thu, Jun 29, 2023 at 04:45:41PM +0200, Helge Deller wrote: > Hi Greg, > > below is the manual backport of an upstream patch to fix the build failure > in kernel v4.14 in imsttfb.c. > > It's not sufficient to just return from init_imstt() as the kernel then > may crash later when it tries to access the non-existent framebuffer or > cmap. Instead return failure to imsttfb_probe() so that the kernel > will skip using that hardware/driver. > > Can you please apply this patch to the v4.14 stable queue? Now queued up, thanks! greg k-h