public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Michael Schmitz <schmitzmic@gmail.com>
To: linux-block@vger.kernel.org, axboe@kernel.dk
Cc: linux-m68k@vger.kernel.org, chzigotzky@xenosoft.de,
	geert@linux-m68k.org, hch@lst.de, martin@lichtvoll.de,
	Michael Schmitz <schmitzmic@gmail.com>,
	stable@vger.kernel.org
Subject: [PATCH] block: bugfix for Amiga partition overflow check patch
Date: Sat,  1 Jul 2023 14:35:24 +1200	[thread overview]
Message-ID: <20230701023524.7434-1-schmitzmic@gmail.com> (raw)

Making 'blk' sector_t (i.e. 64 bit if LBD support is active)
fails the 'blk>0' test in the partition block loop if a
value of (signed int) -1 is used to mark the end of the
partition block list.

This bug was introduced in patch 3 of my prior Amiga partition
support fixes series, and spotted by Christian Zigotzky when
testing the latest block updates.

Explicitly cast 'blk' to signed int to allow use of -1 to
terminate the partition block linked list.

Reported-by: Christian Zigotzky <chzigotzky@xenosoft.de>
Fixes: b6f3f28f60 ("Linux 6.4")
Message-ID: 024ce4fa-cc6d-50a2-9aae-3701d0ebf668@xenosoft.de
Cc: <stable@vger.kernel.org> # 6.4
Link: https://lore.kernel.org/r/024ce4fa-cc6d-50a2-9aae-3701d0ebf668@xenosoft.de
Signed-off-by: Michael Schmitz <schmitzmic@gmail.com>
---
 block/partitions/amiga.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block/partitions/amiga.c b/block/partitions/amiga.c
index ed222b9c901b..506921095412 100644
--- a/block/partitions/amiga.c
+++ b/block/partitions/amiga.c
@@ -90,7 +90,7 @@ int amiga_partition(struct parsed_partitions *state)
 	}
 	blk = be32_to_cpu(rdb->rdb_PartitionList);
 	put_dev_sector(sect);
-	for (part = 1; blk>0 && part<=16; part++, put_dev_sector(sect)) {
+	for (part = 1; (s32) blk>0 && part<=16; part++, put_dev_sector(sect)) {
 		/* Read in terms partition table understands */
 		if (check_mul_overflow(blk, (sector_t) blksize, &blk)) {
 			pr_err("Dev %s: overflow calculating partition block %llu! Skipping partitions %u and beyond\n",
-- 
2.17.1


             reply	other threads:[~2023-07-01  2:38 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-01  2:35 Michael Schmitz [this message]
2023-07-01  6:40 ` [PATCH] block: bugfix for Amiga partition overflow check patch Christian Zigotzky
2023-07-01  8:11   ` Michael Schmitz
2023-07-01  9:48     ` Christian Zigotzky
2023-07-02  2:17       ` Michael Schmitz
2023-07-02  3:45         ` Michael Schmitz
2023-07-02  4:37         ` Christian Zigotzky
2023-07-02  7:55           ` Martin Steigerwald
2023-07-02  8:56             ` Christian Zigotzky
2023-07-02  9:34               ` Christian Zigotzky
2023-07-02  9:51                 ` John Paul Adrian Glaubitz
2023-07-02 10:34                 ` Martin Steigerwald
2023-07-03  1:57                 ` Michael Schmitz
2023-07-02 20:22             ` Michael Schmitz
2023-07-03  7:05               ` Martin Steigerwald
2023-07-03 14:19                 ` Christian Zigotzky
2023-07-03 14:59                   ` Christian Zigotzky
2023-07-03 21:24                     ` Michael Schmitz
2023-07-03 21:27                       ` Jens Axboe
2023-07-03 22:43                         ` Michael Schmitz
2023-07-04  5:06                       ` John Paul Adrian Glaubitz
2023-07-04  5:44                         ` Michael Schmitz
2023-07-04  5:48                           ` John Paul Adrian Glaubitz
2023-07-04  5:58                             ` Michael Schmitz
2023-07-04  7:28                               ` Martin Steigerwald

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230701023524.7434-1-schmitzmic@gmail.com \
    --to=schmitzmic@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=chzigotzky@xenosoft.de \
    --cc=geert@linux-m68k.org \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-m68k@vger.kernel.org \
    --cc=martin@lichtvoll.de \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox