From: Alex Deucher <alexander.deucher@amd.com>
To: <stable@vger.kernel.org>
Cc: mario.limonciello@amd.com,
"Alex Deucher" <alexander.deucher@amd.com>,
"Felix Kuehling" <Felix.Kuehling@amd.com>,
"Aaron Liu" <aaron.liu@amd.com>,
"Christian König" <christian.koenig@amd.com>
Subject: [PATCH 5/9] drm/amdgpu/sdma4: set align mask to 255
Date: Fri, 7 Jul 2023 11:07:30 -0400 [thread overview]
Message-ID: <20230707150734.746135-5-alexander.deucher@amd.com> (raw)
In-Reply-To: <20230707150734.746135-1-alexander.deucher@amd.com>
The wptr needs to be incremented at at least 64 dword intervals,
use 256 to align with windows. This should fix potential hangs
with unaligned updates.
Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>
Reviewed-by: Aaron Liu <aaron.liu@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
(cherry picked from commit e5df16d9428f5c6d2d0b1eff244d6c330ba9ef3a)
Cc: stable@vger.kernel.org
---
drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 4 ++--
drivers/gpu/drm/amd/amdgpu/sdma_v4_4_2.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c
index 9295ac7edd56..d35c8a33d06d 100644
--- a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c
@@ -2306,7 +2306,7 @@ const struct amd_ip_funcs sdma_v4_0_ip_funcs = {
static const struct amdgpu_ring_funcs sdma_v4_0_ring_funcs = {
.type = AMDGPU_RING_TYPE_SDMA,
- .align_mask = 0xf,
+ .align_mask = 0xff,
.nop = SDMA_PKT_NOP_HEADER_OP(SDMA_OP_NOP),
.support_64bit_ptrs = true,
.secure_submission_supported = true,
@@ -2338,7 +2338,7 @@ static const struct amdgpu_ring_funcs sdma_v4_0_ring_funcs = {
static const struct amdgpu_ring_funcs sdma_v4_0_page_ring_funcs = {
.type = AMDGPU_RING_TYPE_SDMA,
- .align_mask = 0xf,
+ .align_mask = 0xff,
.nop = SDMA_PKT_NOP_HEADER_OP(SDMA_OP_NOP),
.support_64bit_ptrs = true,
.secure_submission_supported = true,
diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v4_4_2.c b/drivers/gpu/drm/amd/amdgpu/sdma_v4_4_2.c
index 64dcaa2670dd..ac7aa8631f6a 100644
--- a/drivers/gpu/drm/amd/amdgpu/sdma_v4_4_2.c
+++ b/drivers/gpu/drm/amd/amdgpu/sdma_v4_4_2.c
@@ -1740,7 +1740,7 @@ const struct amd_ip_funcs sdma_v4_4_2_ip_funcs = {
static const struct amdgpu_ring_funcs sdma_v4_4_2_ring_funcs = {
.type = AMDGPU_RING_TYPE_SDMA,
- .align_mask = 0xf,
+ .align_mask = 0xff,
.nop = SDMA_PKT_NOP_HEADER_OP(SDMA_OP_NOP),
.support_64bit_ptrs = true,
.get_rptr = sdma_v4_4_2_ring_get_rptr,
@@ -1771,7 +1771,7 @@ static const struct amdgpu_ring_funcs sdma_v4_4_2_ring_funcs = {
static const struct amdgpu_ring_funcs sdma_v4_4_2_page_ring_funcs = {
.type = AMDGPU_RING_TYPE_SDMA,
- .align_mask = 0xf,
+ .align_mask = 0xff,
.nop = SDMA_PKT_NOP_HEADER_OP(SDMA_OP_NOP),
.support_64bit_ptrs = true,
.get_rptr = sdma_v4_4_2_ring_get_rptr,
--
2.41.0
next prev parent reply other threads:[~2023-07-07 15:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-07 15:07 [PATCH 1/9] drm/amdgpu: make sure BOs are locked in amdgpu_vm_get_memory Alex Deucher
2023-07-07 15:07 ` [PATCH 2/9] drm/amdgpu: make sure that BOs have a backing store Alex Deucher
2023-07-07 15:07 ` [PATCH 3/9] drm/amdgpu: Skip mark offset for high priority rings Alex Deucher
2023-07-07 15:07 ` [PATCH 4/9] drm/amd/pm: revise the ASPM settings for thunderbolt attached scenario Alex Deucher
2023-07-07 15:07 ` Alex Deucher [this message]
2023-07-07 15:07 ` [PATCH 6/9] drm/amd/pm: add abnormal fan detection for smu 13.0.0 Alex Deucher
2023-07-07 15:07 ` [PATCH 7/9] drm/amdgpu: check RAS irq existence for VCN/JPEG Alex Deucher
2023-07-07 15:07 ` [PATCH 8/9] drm/amdgpu: fix number of fence calculations Alex Deucher
2023-07-07 15:07 ` [PATCH 9/9] drm/amd: Don't try to enable secure display TA multiple times Alex Deucher
2023-07-11 21:40 ` [PATCH 1/9] drm/amdgpu: make sure BOs are locked in amdgpu_vm_get_memory Mario Limonciello
2023-07-12 5:12 ` Greg Kroah-Hartman
2023-07-16 19:16 ` Greg KH
2023-07-16 19:22 ` Mario Limonciello
2023-07-16 19:28 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230707150734.746135-5-alexander.deucher@amd.com \
--to=alexander.deucher@amd.com \
--cc=Felix.Kuehling@amd.com \
--cc=aaron.liu@amd.com \
--cc=christian.koenig@amd.com \
--cc=mario.limonciello@amd.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox