From: Christoph Hellwig <hch@lst.de>
To: Christian Brauner <brauner@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Christoph Hellwig <hch@lst.de>,
Florian Weimer <fweimer@redhat.com>,
Aleksa Sarai <cyphar@cyphar.com>,
linux-fsdevel@vger.kernel.org, Al Viro <viro@zeniv.linux.org.uk>,
stable@vger.kernel.org
Subject: Re: [PATCH v2] attr: block mode changes of symlinks
Date: Thu, 13 Jul 2023 14:00:42 +0200 [thread overview]
Message-ID: <20230713120042.GA23709@lst.de> (raw)
In-Reply-To: <20230712-vfs-chmod-symlinks-v2-1-08cfb92b61dd@kernel.org>
On Wed, Jul 12, 2023 at 08:58:49PM +0200, Christian Brauner wrote:
> (1) Filesystems that don't implement a i_op->setattr() for symlinks.
>
> Such filesystems may or may not know that without i_op->setattr()
> defined, notify_change() falls back to simple_setattr() causing the
> inode's mode in the inode cache to be changed.
Btw, I think this fallback is pretty harmful. At some point we should
probably start auditing all instances and wire the ones up that should
be using simple_setattr (probably mostly just in-memory file systems)
and refuse attribute changes if .setattr is NULL.
next prev parent reply other threads:[~2023-07-13 12:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-12 18:58 [PATCH v2] attr: block mode changes of symlinks Christian Brauner
2023-07-13 7:37 ` Christian Brauner
2023-07-13 11:40 ` Christoph Hellwig
2023-07-13 12:10 ` Christian Brauner
2023-07-13 12:00 ` Christoph Hellwig [this message]
2023-07-13 12:14 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230713120042.GA23709@lst.de \
--to=hch@lst.de \
--cc=brauner@kernel.org \
--cc=cyphar@cyphar.com \
--cc=fweimer@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox