Fwd: dwc3: regression in USB DWC3 driver in kernel 5.15 branch

Fwd: dwc3: regression in USB DWC3 driver in kernel 5.15 branch

[Bagas Sanjaya]

Hi,

I notice a stable-specific regression on Bugzilla [1]. Quoting from it:

> The backport commit to 5.15 branch:
> 9d4f84a15f9c9727bc07f59d9dafc89e65aadb34 "arm64: dts: imx8mp: Add snps,gfladj-refclk-lpm-sel quirk to USB nodes"  (from upstream commit 5c3d5ecf48ab06c709c012bf1e8f0c91e1fcd7ad)
> switched from "snps,dis-u2-freeclk-exists-quirk" to "snps,gfladj-refclk-lpm-sel-quirk".
> 
> The problem is that the gfladj-refclk-lpm-sel-quirk quirk is not implemented / backported to 5.15 branch.
> 
> This commit should be either reverted, or the commit introducing gfladj-refclk-lpm-sel-quirk needs to be merged to 5.15 kernel branch.
> 
> As a result of this patch, on Gateworks Venice GW7400 revB board the USB 3.x devices which are connected to the USB Type C port does not enumerate and the following errors are generated:
> 
> [   14.906302] xhci-hcd xhci-hcd.0.auto: Timeout while waiting for setup device command
> [   15.122383] usb 2-1: device not accepting address 2, error -62
> [   25.282195] xhci-hcd xhci-hcd.0.auto: Abort failed to stop command ring: -110
> [   25.297408] xhci-hcd xhci-hcd.0.auto: xHCI host controller not responding, assume dead
> [   25.305345] xhci-hcd xhci-hcd.0.auto: HC died; cleaning up
> [   25.311058] xhci-hcd xhci-hcd.0.auto: Timeout while waiting for stop endpoint command
> [   25.334361] usb usb2-port1: couldn't allocate usb_device
> 
> When the commit is reverted the USB 3.x drives works fine.

See Bugzilla for the full thread and attach dmesgs.

Anyway, I'm adding it to regzbot:

#regzbot introduced: 9d4f84a15f9c97 https://bugzilla.kernel.org/show_bug.cgi?id=217670
#regzbot title: regression in USB DWC3 driver due to missing gfladj-refclk-lpm-sel-quirk quirk

Thanks.

[1]: https://bugzilla.kernel.org/show_bug.cgi?id=217670

-- 
An old man doll... just what I always wanted! - Clara

Re: Fwd: dwc3: regression in USB DWC3 driver in kernel 5.15 branch

[Greg Kroah-Hartman]

On Sat, Jul 15, 2023 at 06:03:06PM +0700, Bagas Sanjaya wrote:
> Hi,
> 
> I notice a stable-specific regression on Bugzilla [1]. Quoting from it:
> 
> > The backport commit to 5.15 branch:
> > 9d4f84a15f9c9727bc07f59d9dafc89e65aadb34 "arm64: dts: imx8mp: Add snps,gfladj-refclk-lpm-sel quirk to USB nodes"  (from upstream commit 5c3d5ecf48ab06c709c012bf1e8f0c91e1fcd7ad)
> > switched from "snps,dis-u2-freeclk-exists-quirk" to "snps,gfladj-refclk-lpm-sel-quirk".
> > 
> > The problem is that the gfladj-refclk-lpm-sel-quirk quirk is not implemented / backported to 5.15 branch.
> > 
> > This commit should be either reverted, or the commit introducing gfladj-refclk-lpm-sel-quirk needs to be merged to 5.15 kernel branch.
> > 
> > As a result of this patch, on Gateworks Venice GW7400 revB board the USB 3.x devices which are connected to the USB Type C port does not enumerate and the following errors are generated:
> > 
> > [   14.906302] xhci-hcd xhci-hcd.0.auto: Timeout while waiting for setup device command
> > [   15.122383] usb 2-1: device not accepting address 2, error -62
> > [   25.282195] xhci-hcd xhci-hcd.0.auto: Abort failed to stop command ring: -110
> > [   25.297408] xhci-hcd xhci-hcd.0.auto: xHCI host controller not responding, assume dead
> > [   25.305345] xhci-hcd xhci-hcd.0.auto: HC died; cleaning up
> > [   25.311058] xhci-hcd xhci-hcd.0.auto: Timeout while waiting for stop endpoint command
> > [   25.334361] usb usb2-port1: couldn't allocate usb_device
> > 
> > When the commit is reverted the USB 3.x drives works fine.
> 
> See Bugzilla for the full thread and attach dmesgs.
> 
> Anyway, I'm adding it to regzbot:
> 
> #regzbot introduced: 9d4f84a15f9c97 https://bugzilla.kernel.org/show_bug.cgi?id=217670
> #regzbot title: regression in USB DWC3 driver due to missing gfladj-refclk-lpm-sel-quirk quirk

This isn't helpful as I don't know what commit eactly this missing
quirk is :(

Re: Fwd: dwc3: regression in USB DWC3 driver in kernel 5.15 branch

[Linux regression tracking (Thorsten Leemhuis)]

On 15.07.23 13:03, Bagas Sanjaya wrote:
> 
> I notice a stable-specific regression on Bugzilla [1]. Quoting from it:
> 
>> The backport commit to 5.15 branch:
>> 9d4f84a15f9c9727bc07f59d9dafc89e65aadb34 "arm64: dts: imx8mp: Add snps,gfladj-refclk-lpm-sel quirk to USB nodes"  (from upstream commit 5c3d5ecf48ab06c709c012bf1e8f0c91e1fcd7ad)
>> switched from "snps,dis-u2-freeclk-exists-quirk" to "snps,gfladj-refclk-lpm-sel-quirk".
>> [...]
>> When the commit is reverted the USB 3.x drives works fine.
> 
> See Bugzilla for the full thread and attach dmesgs.
> 
> Anyway, I'm adding it to regzbot:
> 
> #regzbot introduced: 9d4f84a15f9c97 https://bugzilla.kernel.org/show_bug.cgi?id=217670
> #regzbot title: regression in USB DWC3 driver due to missing gfladj-refclk-lpm-sel-quirk quirk
> 
> [1]: https://bugzilla.kernel.org/show_bug.cgi?id=217670

Tomasz, it looks like you were really close at resolving this regression
when you submitted the required patches for the 5.15.y branch a few
weeks ago:
https://lore.kernel.org/all/2023090417-silk-parting-36d8@gregkh/

What happened? Did you loose interest? Did you not understand what Greg
asked for? Do you need help?

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
If I did something stupid, please tell me, as explained on that page.

#regzbot poke

Re: Fwd: dwc3: regression in USB DWC3 driver in kernel 5.15 branch

[Thorsten Leemhuis]

Hi. Top-posting for once, to make this easily accessible to everyone.

To Greg and everyone that might care: apparently Tomasz lost interest in
fixing this 5.15.y regression. Kinda sad, as the patches are mostly
there, but lack a S-o-b tag -- which means we are stuck here, unless
somebody else attempts a backport.

https://lore.kernel.org/all/20230904071432.32309-1-tomasz.rostanski@thalesgroup.com/

I'll thus stop tracking this regression.

#regzbot inconclusive: unfixed afaic, as patches to fix this got stuck
#regzbot ignore-activity

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
If I did something stupid, please tell me, as explained on that page.

On 01.11.23 19:59, Linux regression tracking (Thorsten Leemhuis) wrote:
> On 15.07.23 13:03, Bagas Sanjaya wrote:
>> I notice a stable-specific regression on Bugzilla [1]. Quoting from it:
>>> The backport commit to 5.15 branch:
>>> 9d4f84a15f9c9727bc07f59d9dafc89e65aadb34 "arm64: dts: imx8mp: Add snps,gfladj-refclk-lpm-sel quirk to USB nodes"  (from upstream commit 5c3d5ecf48ab06c709c012bf1e8f0c91e1fcd7ad)
>>> switched from "snps,dis-u2-freeclk-exists-quirk" to "snps,gfladj-refclk-lpm-sel-quirk".
>>> [...]
>>> When the commit is reverted the USB 3.x drives works fine.
>>
>> See Bugzilla for the full thread and attach dmesgs.
>>
>> Anyway, I'm adding it to regzbot:
>>
>> #regzbot introduced: 9d4f84a15f9c97 https://bugzilla.kernel.org/show_bug.cgi?id=217670
>> #regzbot title: regression in USB DWC3 driver due to missing gfladj-refclk-lpm-sel-quirk quirk
>>
>> [1]: https://bugzilla.kernel.org/show_bug.cgi?id=217670
> 
> Tomasz, it looks like you were really close at resolving this regression
> when you submitted the required patches for the 5.15.y branch a few
> weeks ago:
> https://lore.kernel.org/all/2023090417-silk-parting-36d8@gregkh/
> 
> What happened? Did you loose interest? Did you not understand what Greg
> asked for? Do you need help?
> 
> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
> --
> Everything you wanna know about Linux kernel regression tracking:
> https://linux-regtracking.leemhuis.info/about/#tldr
> If I did something stupid, please tell me, as explained on that page.
> 
> #regzbot poke

Re: Fwd: dwc3: regression in USB DWC3 driver in kernel 5.15 branch

[Greg Kroah-Hartman]

On Tue, Nov 21, 2023 at 04:25:30PM +0100, Thorsten Leemhuis wrote:
> Hi. Top-posting for once, to make this easily accessible to everyone.
> 
> To Greg and everyone that might care: apparently Tomasz lost interest in
> fixing this 5.15.y regression. Kinda sad, as the patches are mostly
> there, but lack a S-o-b tag -- which means we are stuck here, unless
> somebody else attempts a backport.
> 
> https://lore.kernel.org/all/20230904071432.32309-1-tomasz.rostanski@thalesgroup.com/
> 
> I'll thus stop tracking this regression.

Thanks, I'll wait for a working backport for those using the 5.15.y tree
and this driver as it's not anything that I am capable of doing at this
point in time.

greg k-h