From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Nathan Chancellor <nathan@kernel.org>
Cc: Naresh Kamboju <naresh.kamboju@linaro.org>,
Sasha Levin <sashal@kernel.org>,
linux-stable <stable@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
clang-built-linux <llvm@lists.linux.dev>,
lkft-triage@lists.linaro.org,
Nick Desaulniers <ndesaulniers@google.com>,
Anders Roxell <anders.roxell@linaro.org>
Subject: Re: stable-rc 6.1: x86: clang build failed - block/blk-cgroup.c:1237:6: error: variable 'ret' is used uninitialized whenever 'if' condition is true
Date: Mon, 17 Jul 2023 20:47:17 +0200 [thread overview]
Message-ID: <2023071705-enforced-overplant-fd80@gregkh> (raw)
In-Reply-To: <20230717132426.GA2561862@dev-arch.thelio-3990X>
On Mon, Jul 17, 2023 at 06:24:26AM -0700, Nathan Chancellor wrote:
> On Mon, Jul 17, 2023 at 12:55:42AM +0530, Naresh Kamboju wrote:
> > Linux stable-rc 6.1 build failed x86 and i386 with clang.
> >
> > Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> >
> > Build log:
> > -----------
> > block/blk-cgroup.c:1237:6: error: variable 'ret' is used uninitialized
> > whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized]
> > if (init_blkcg_llists(blkcg))
> > ^~~~~~~~~~~~~~~~~~~~~~~~
> > block/blk-cgroup.c:1287:9: note: uninitialized use occurs here
> > return ret;
> > ^~~
> > block/blk-cgroup.c:1237:2: note: remove the 'if' if its condition is
> > always false
> > if (init_blkcg_llists(blkcg))
> > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > block/blk-cgroup.c:1222:33: note: initialize the variable 'ret' to
> > silence this warning
> > struct cgroup_subsys_state *ret;
> > ^
> > = NULL
> > 1 error generated.
> >
> > Links,
> > - https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-6.1.y-sanity/build/v6.1.38-599-g5071846d06ef/testrun/18327562/suite/build/test/clang-lkftconfig/history/
> > - https://storage.tuxsuite.com/public/linaro/lkft/builds/2SfFoWj9NmKWHRijR0hcoXGjLhr/
> >
> > tuxmake \
> > --runtime podman --target-arch x86_64 \
> > --toolchain clang-16 \
> > --kconfig https://storage.tuxsuite.com/public/linaro/lkft/builds/2SfFoWj9NmKWHRijR0hcoXGjLhr/config
> > \
> > LLVM=1 LLVM_IAS=1
> >
>
> It looks like 6.1 needs commit b5a9adcbd5dc ("blk-cgroup: Return -ENOMEM
> directly in blkcg_css_alloc() error path") if it wants to take commit
> 3b8cc6298724 ("blk-cgroup: Optimize blkcg_rstat_flush()").
I'm going to drop the offending patch now, thanks.
greg k-h
prev parent reply other threads:[~2023-07-17 18:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-16 19:25 stable-rc 6.1: x86: clang build failed - block/blk-cgroup.c:1237:6: error: variable 'ret' is used uninitialized whenever 'if' condition is true Naresh Kamboju
2023-07-17 13:24 ` Nathan Chancellor
2023-07-17 18:47 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023071705-enforced-overplant-fd80@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=anders.roxell@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkft-triage@lists.linaro.org \
--cc=llvm@lists.linux.dev \
--cc=naresh.kamboju@linaro.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox