From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 838FDEB64DA for ; Tue, 18 Jul 2023 14:45:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230476AbjGROpE (ORCPT ); Tue, 18 Jul 2023 10:45:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60478 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231132AbjGROpE (ORCPT ); Tue, 18 Jul 2023 10:45:04 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B962F9 for ; Tue, 18 Jul 2023 07:45:03 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AE649615AC for ; Tue, 18 Jul 2023 14:45:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A51EAC433C8; Tue, 18 Jul 2023 14:45:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1689691502; bh=YSJxxm0ASw/+kopkaCasJqo44Ppw0xYGx0FJZv6SwSo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=0S1GNq2KyCC7fadgFe8KlTxuz3ZC9YnTaQlYHk6Ez8k5saDcy5OXDQGqBBWNeYGB3 fn2dNwcw/t01QwoQ5MnHyL8J8G6ssfDK9jyxAXkWsJTp3utUJI3yAuc/UdT7JlBI/g kHvLqGWmHsYwhiIdbglOWdT4c+Uq9P96Hed3IOB0= Date: Tue, 18 Jul 2023 16:44:58 +0200 From: Greg KH To: Joel Fernandes Cc: Yu Kuai , stable , Guenter Roeck , "yukuai (C)" Subject: Re: Build failures / crashes in stable queue branches Message-ID: <2023071840-hatchling-fiction-65a8@gregkh> References: <897ebb05-5a1f-e353-8877-49721c52d065@roeck-us.net> <20230715154923.GA2193946@google.com> <907909df-d64f-e40a-0c9c-fc5c225a235c@huaweicloud.com> <2023071625-parsnip-pursuable-b5c8@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Tue, Jul 18, 2023 at 09:52:45AM -0400, Joel Fernandes wrote: > On 7/16/23 10:30, Greg KH wrote: > > On Sun, Jul 16, 2023 at 11:20:33AM +0800, Yu Kuai wrote: > > > Hi, > > > > > > 在 2023/07/15 23:49, Joel Fernandes 写道: > > > > Hi Yu, > > > > > > > > On Fri, Jul 14, 2023 at 03:21:46AM -0700, Guenter Roeck wrote: > > > > [..] > > > > > --------- > > > > > 6.1.y: > > > > > > > > > > Build reference: v6.1.38-393-gb6386e7314b4 > > > > > Compiler version: alpha-linux-gcc (GCC) 11.4.0 > > > > > Assembler version: GNU assembler (GNU Binutils) 2.40 > > > > > > > > > > Building alpha:allmodconfig ... failed > > > > > Building m68k:allmodconfig ... failed > > > > > -------------- > > > > > Error log: > > > > > :1517:2: warning: #warning syscall clone3 not implemented [-Wcpp] > > > > > In file included from block/genhd.c:28: > > > > > block/genhd.c: In function 'disk_release': > > > > > include/linux/blktrace_api.h:88:57: error: statement with no effect [-Werror=unused-value] > > > > > 88 | # define blk_trace_remove(q) (-ENOTTY) > > > > > | ^ > > > > > block/genhd.c:1185:9: note: in expansion of macro 'blk_trace_remove' > > > > > 1185 | blk_trace_remove(disk->queue); > > > > > > > > 6.1 stable is broken and gives build warning without: > > > > > > > > cbe7cff4a76b ("blktrace: use inline function for blk_trace_remove() while blktrace is disabled") > > > > > > > > Could you please submit it to stable for 6.1? (I could have done that but it > > > > looks like you already backported related patches so its best for you to do > > > > it, thanks for your help!). > > > > > > Thanks for the notice, however, I'll suggest to revert this patch for > > > now, because there are follow up fixes that is not applied yet. > > > > Which specific patch should be dropped? > > > > Yu: Ping? ;-). Are you suggesting the original set be reverted, or Greg > apply the above fix? Let us please keep 6.1 stable unbroken. ;-) > > Apologies for my noise if the issue has already been resolved. I think it has been resolved, but testing against the latest -rc release I sent out yesterday would be appreciated. thanks, greg k-h