From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E83BC001B0 for ; Sun, 23 Jul 2023 20:34:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229692AbjGWUer (ORCPT ); Sun, 23 Jul 2023 16:34:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38348 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229708AbjGWUeq (ORCPT ); Sun, 23 Jul 2023 16:34:46 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD374E49 for ; Sun, 23 Jul 2023 13:34:45 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AE11160E9D for ; Sun, 23 Jul 2023 20:34:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 881CFC433C8; Sun, 23 Jul 2023 20:34:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1690144484; bh=9WgpUAOc96B6MygGPgzEPDsjIP9TxlbrSmGa6QoZwIM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dnXlFkC4eqyy8CCJpQUsv1drhveAWkoP2ySZaSbHfEIUfKlWqeugHAu+5X8QKI+g+ W+8rmr/hw87JcmyUs92jWXjV9cED4Xp9O0d8mYLpEfmaZGWdjSAXYrE8AGNzWilIRq bYRAaJ2l7OtytbbfJQacLYFiYQRICtf/ZTQ38DNA= Date: Sun, 23 Jul 2023 22:34:41 +0200 From: Greg KH To: Christophe JAILLET Cc: stable@vger.kernel.org, Linus Walleij , Andi Shyti Subject: Re: [PATCH 6.4.y] i2c: busses: i2c-nomadik: Remove a useless call in the remove function Message-ID: <2023072303-ranking-wife-05ae@gregkh> References: <2023072154-animal-dropkick-6a92@gregkh> <62fe6800d41e04a4eb5adfa18a9e1090cbc72256.1688160163.git.christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <62fe6800d41e04a4eb5adfa18a9e1090cbc72256.1688160163.git.christophe.jaillet@wanadoo.fr> Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Fri, Jul 21, 2023 at 07:47:41PM +0200, Christophe JAILLET wrote: > Since commit 235602146ec9 ("i2c-nomadik: turn the platform driver to an amba > driver"), there is no more request_mem_region() call in this driver. > > So remove the release_mem_region() call from the remove function which is > likely a left over. > > Fixes: 235602146ec9 ("i2c-nomadik: turn the platform driver to an amba driver") > Cc: # v3.6+ > Acked-by: Linus Walleij > Reviewed-by: Andi Shyti > Signed-off-by: Christophe JAILLET > --- > The patch below that should fix a merge conflict related to commit > 9c7174db4cdd1 ("i2c: nomadik: Use devm_clk_get_enabled()") has been > HAND MODIFIED. I don't understand, that commit is not in the stable trees. What do you mean by "hand modified"? > I hope it is fine, but is provided as-is. Especially line numbers should be > wrong, but 'patch' should be able to deal with it. (sorry if it does not apply) > > I guess that it should also apply to all previous branches. > > I've left the commit description as it was. Not sure what to do with A-b and R-b > tags. Why isn't this needed in Linus's tree? confused, greg k-h