From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A0E7C001B0 for ; Mon, 24 Jul 2023 01:51:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232793AbjGXBvT (ORCPT ); Sun, 23 Jul 2023 21:51:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54308 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230015AbjGXBvC (ORCPT ); Sun, 23 Jul 2023 21:51:02 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 22F1D1994; Sun, 23 Jul 2023 18:42:16 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F251060FBB; Mon, 24 Jul 2023 01:37:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 17DA6C433C9; Mon, 24 Jul 2023 01:37:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690162621; bh=rSjN3IcZbqFDf3fYlmZAU3hQZGUDuAwj/Ce5GEIWCXY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=l0/IF8/BkXojGwD8oAcZMRCN0ttdMXANQoaVOY32jqIl/BBRLP+ZSWuBqjQ0rbHDl 4FM3U0O8RXEyWnC9xYPc7NKpnwCrnyI2d2czKz+Z2hJXZpoGo9lw0HsypLM3R4Ojcp J0YwsY+77rOOR6NeCY0/fs0Q4eNtIbwJeFeByrbErUydzpHne1C2TxEYJiHdy4T9/p 9JCCn3dywjT7BGpu/wHDChCFSLqQC+f6YtMWEIbnH1zmLqd4aEMsG/u+edIFVhNKa5 2L8eBCvu3Yx2oNLLinJ4s17HI5d0Eui6wFYpPFqE5MY3t5g+RyL3HejBCe04MQlwKm 8mdcE1D8mrS5w== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Zhengping Jiang , Luiz Augusto von Dentz , Jakub Kicinski , Sasha Levin , marcel@holtmann.org, gustavo@padovan.org, johan.hedberg@gmail.com, davem@davemloft.net, linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 7/9] Bluetooth: L2CAP: Fix use-after-free Date: Sun, 23 Jul 2023 21:35:49 -0400 Message-Id: <20230724013554.2334965-7-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230724013554.2334965-1-sashal@kernel.org> References: <20230724013554.2334965-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 4.14.320 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Zhengping Jiang [ Upstream commit f752a0b334bb95fe9b42ecb511e0864e2768046f ] Fix potential use-after-free in l2cap_le_command_rej. Signed-off-by: Zhengping Jiang Signed-off-by: Luiz Augusto von Dentz Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- net/bluetooth/l2cap_core.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c index 25d88b8cfae97..6bae68b5d439c 100644 --- a/net/bluetooth/l2cap_core.c +++ b/net/bluetooth/l2cap_core.c @@ -5705,9 +5705,14 @@ static inline int l2cap_le_command_rej(struct l2cap_conn *conn, if (!chan) goto done; + chan = l2cap_chan_hold_unless_zero(chan); + if (!chan) + goto done; + l2cap_chan_lock(chan); l2cap_chan_del(chan, ECONNREFUSED); l2cap_chan_unlock(chan); + l2cap_chan_put(chan); done: mutex_unlock(&conn->chan_lock); -- 2.39.2