From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21D99C001E0 for ; Tue, 25 Jul 2023 11:06:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234013AbjGYLGr (ORCPT ); Tue, 25 Jul 2023 07:06:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44790 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234014AbjGYLGb (ORCPT ); Tue, 25 Jul 2023 07:06:31 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4370146BE for ; Tue, 25 Jul 2023 04:04:55 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CD55F6166E for ; Tue, 25 Jul 2023 11:04:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DD6F9C433C8; Tue, 25 Jul 2023 11:04:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1690283094; bh=lVb9P3WrInp7+yGTFvEGQcLlrKopVv0U6+cKuQqqQxE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=M13jix3Xw6hGld4gYyaDC91G1Zi3rX6Dv73MABusBPVKZr1gBw6CruRRc9ZV3W6Mk QE/ae/nWIAKwQ0hpe07qVKOB7aX6OGELHjfiWhRSnBupIzvxJrdKpEVKrUxuyNHrod mv0Fpr7BTEDvMqEBUbg3mx/8JlKO7rXQxqrVO8v8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Wang Ming , Tariq Toukan , Kuniyuki Iwashima , "David S. Miller" , Sasha Levin Subject: [PATCH 6.1 137/183] net: ipv4: Use kfree_sensitive instead of kfree Date: Tue, 25 Jul 2023 12:46:05 +0200 Message-ID: <20230725104512.853139596@linuxfoundation.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230725104507.756981058@linuxfoundation.org> References: <20230725104507.756981058@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Wang Ming [ Upstream commit daa751444fd9d4184270b1479d8af49aaf1a1ee6 ] key might contain private part of the key, so better use kfree_sensitive to free it. Fixes: 38320c70d282 ("[IPSEC]: Use crypto_aead and authenc in ESP") Signed-off-by: Wang Ming Reviewed-by: Tariq Toukan Reviewed-by: Kuniyuki Iwashima Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- net/ipv4/esp4.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv4/esp4.c b/net/ipv4/esp4.c index 52c8047efedbb..2d094d417ecae 100644 --- a/net/ipv4/esp4.c +++ b/net/ipv4/esp4.c @@ -1132,7 +1132,7 @@ static int esp_init_authenc(struct xfrm_state *x, err = crypto_aead_setkey(aead, key, keylen); free_key: - kfree(key); + kfree_sensitive(key); error: return err; -- 2.39.2