From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00A4EC41513 for ; Tue, 25 Jul 2023 18:39:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231622AbjGYSjc (ORCPT ); Tue, 25 Jul 2023 14:39:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44330 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230328AbjGYSjb (ORCPT ); Tue, 25 Jul 2023 14:39:31 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0AB0EA3 for ; Tue, 25 Jul 2023 11:39:31 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9BF226181E for ; Tue, 25 Jul 2023 18:39:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B0433C433C7; Tue, 25 Jul 2023 18:39:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1690310370; bh=Uw9m574mjK/0Ei7oniQtpFxXW1q8JHO3VH8+PxQI2CA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZGEFUCNKwoWqycpQvYWdIGzZh32HEIaGW1D7SsOrwMl7znohLPf0anaUfTGuEL3oW lbmWtvgJEhkOzQzYi366/Es5uRaKMNAG5VKUayKej66M7pGLX+kJzgfVbr5i5LWxdn qVMrLNH6DDoKKtXEZePe8t1Hx3jHGJG9o7h0DGUE= Date: Tue, 25 Jul 2023 20:39:27 +0200 From: Greg KH To: Mat Martineau Cc: Matthieu Baerts , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Geliang Tang , netdev@vger.kernel.org, mptcp@lists.linux.dev, stable@vger.kernel.org Subject: Re: [PATCH net 1/2] selftests: mptcp: join: only check for ip6tables if needed Message-ID: <2023072521-surfboard-starry-fbe8@gregkh> References: <20230725-send-net-20230725-v1-0-6f60fe7137a9@kernel.org> <20230725-send-net-20230725-v1-1-6f60fe7137a9@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230725-send-net-20230725-v1-1-6f60fe7137a9@kernel.org> Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Tue, Jul 25, 2023 at 11:34:55AM -0700, Mat Martineau wrote: > From: Matthieu Baerts > > If 'iptables-legacy' is available, 'ip6tables-legacy' command will be > used instead of 'ip6tables'. So no need to look if 'ip6tables' is > available in this case. > > Fixes: 0c4cd3f86a40 ("selftests: mptcp: join: use 'iptables-legacy' if available") > Acked-by: Paolo Abeni > Signed-off-by: Matthieu Baerts > Signed-off-by: Mat Martineau > --- > tools/testing/selftests/net/mptcp/mptcp_join.sh | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/tools/testing/selftests/net/mptcp/mptcp_join.sh b/tools/testing/selftests/net/mptcp/mptcp_join.sh > index e6c9d5451c5b..3c2096ac97ef 100755 > --- a/tools/testing/selftests/net/mptcp/mptcp_join.sh > +++ b/tools/testing/selftests/net/mptcp/mptcp_join.sh > @@ -162,9 +162,7 @@ check_tools() > elif ! iptables -V &> /dev/null; then > echo "SKIP: Could not run all tests without iptables tool" > exit $ksft_skip > - fi > - > - if ! ip6tables -V &> /dev/null; then > + elif ! ip6tables -V &> /dev/null; then > echo "SKIP: Could not run all tests without ip6tables tool" > exit $ksft_skip > fi > > -- > 2.41.0 > This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly.