From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2BB6EB64DD for ; Wed, 26 Jul 2023 01:28:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229771AbjGZB2m (ORCPT ); Tue, 25 Jul 2023 21:28:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40612 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229676AbjGZB2l (ORCPT ); Tue, 25 Jul 2023 21:28:41 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 063212699 for ; Tue, 25 Jul 2023 18:28:41 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8B937613EA for ; Wed, 26 Jul 2023 01:28:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BCDFAC433C8; Wed, 26 Jul 2023 01:28:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690334919; bh=QbpbwOxeGXq22fzhkwtyeotKCXt3QbovlkI5XBG2NYA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ACbKBrd7zGLMCiiOL6UFfi/wtjIA/y4FkezgUjQ3PvviyuaV7MbuG+R/R/qfzEmPb ZqlujrRNeGa22UdqjkA7RbwD+izzUMyGUoq6aXLJ5nhelzLYmtkAE2DA8dixAdLBgW oDL69a6OXcbkIAcVYXBm96KtR93/GEzmms+BvdzF2g8jVJj50VK+AdQIi9EoeoCZXz QbMbKxpXYocvXwc0psKsyX1n1gMMPWNJbWATAMafx0tAo5/mB97rEuvCbcZWM3HnnI DSntF0y4EWVAte61wYRgqnzUP9d1vpW+qfuBoZy6FsfUqizZtROU4Y3MQ0fONrrWZe OvFPbsGSS3Kuw== Date: Tue, 25 Jul 2023 18:28:38 -0700 From: Eric Biggers To: Sasha Levin Cc: Greg Kroah-Hartman , stable@vger.kernel.org, patches@lists.linux.dev, Herbert Xu Subject: Re: [PATCH 5.4 113/313] crypto: skcipher - unify the crypto_has_skcipher*() functions Message-ID: <20230726012838.GA7450@sol.localdomain> References: <20230725104521.167250627@linuxfoundation.org> <20230725104525.907419883@linuxfoundation.org> <20230725161343.GA2295@sol.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Tue, Jul 25, 2023 at 09:25:46PM -0400, Sasha Levin wrote: > On Tue, Jul 25, 2023 at 09:13:43AM -0700, Eric Biggers wrote: > > On Tue, Jul 25, 2023 at 12:44:26PM +0200, Greg Kroah-Hartman wrote: > > > From: Eric Biggers > > > > > > [ Upstream commit d3ca75a8b3d77f2788e6c119ea7c3e3a1ab1e1ca ] > > > > > > crypto_has_skcipher() and crypto_has_skcipher2() do the same thing: they > > > check for the availability of an algorithm of type skcipher, blkcipher, > > > or ablkcipher, which also meets any non-type constraints the caller > > > specified. And they have exactly the same prototype. > > > > > > Therefore, eliminate the redundancy by removing crypto_has_skcipher() > > > and renaming crypto_has_skcipher2() to crypto_has_skcipher(). > > > > > > Signed-off-by: Eric Biggers > > > Signed-off-by: Herbert Xu > > > Stable-dep-of: efbc7764c444 ("crypto: marvell/cesa - Fix type mismatch warning") > > > Signed-off-by: Sasha Levin > > > --- > > > crypto/skcipher.c | 4 ++-- > > > include/crypto/skcipher.h | 19 +------------------ > > > 2 files changed, 3 insertions(+), 20 deletions(-) > > > > How is this a Stable-dep-of "crypto: marvell/cesa - Fix type mismatch warning"? > > > > I don't understand why this is being backported. > > You're right - it's not a dep on 5.15 but rather on 5.4, and my failed > optimization attempt did the wrong thing here. Sorry. > I don't see why it would be a dependency on any version. - Eric