From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CB45C001E0 for ; Thu, 27 Jul 2023 10:57:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232037AbjG0K5H (ORCPT ); Thu, 27 Jul 2023 06:57:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42388 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231167AbjG0K5G (ORCPT ); Thu, 27 Jul 2023 06:57:06 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE7922125 for ; Thu, 27 Jul 2023 03:57:05 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8441761E0C for ; Thu, 27 Jul 2023 10:57:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6A855C433C8; Thu, 27 Jul 2023 10:57:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1690455425; bh=HEIL8p98XVLM5cNcWdT7tOqyCSt79F8+VBka/BCAelQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fC8shhl2uGc6dcSsX2UvCYuPSSA5PHZmAwMjsc7T4yn6AyDCoaXRACe8T9WjFU8Ye YregIsIxuzYcDwHywX6C0UYiw+7FKo2i8kQ+faVIfOwIEWXg+vBvxfjBQaWg9ydhkd 1KkoiEvaFe305ZGb7hpPEXIn8iw78cWF6EwH8r0Q= Date: Thu, 27 Jul 2023 12:57:01 +0200 From: Greg Kroah-Hartman To: August Wikerfors Cc: stable@vger.kernel.org, patches@lists.linux.dev, evilsnoo@proton.me, ruinairas1992@gmail.com, nmschulte@gmail.com, Mario Limonciello , Werner Sembach , Chuanhong Guo , "Rafael J. Wysocki" , Sasha Levin Subject: Re: [PATCH 6.4 102/227] ACPI: resource: Remove "Zen" specific match and quirks Message-ID: <2023072744-mulch-repugnant-8d60@gregkh> References: <20230725104514.821564989@linuxfoundation.org> <20230725104518.968673115@linuxfoundation.org> <5fbe6ee8-f907-ffec-7c6d-400aa74eaf20@augustwikerfors.se> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5fbe6ee8-f907-ffec-7c6d-400aa74eaf20@augustwikerfors.se> Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Thu, Jul 27, 2023 at 01:06:25AM +0200, August Wikerfors wrote: > Hi, > > On 2023-07-25 12:44, Greg Kroah-Hartman wrote: > > From: Mario Limonciello > > > > [ Upstream commit a9c4a912b7dc7ff922d4b9261160c001558f9755 ] > > > > commit 9946e39fe8d0 ("ACPI: resource: skip IRQ override on > > AMD Zen platforms") attempted to overhaul the override logic so it > > didn't apply on X86 AMD Zen systems. This was intentional so that > > systems would prefer DSDT values instead of default MADT value for > > IRQ 1 on Ryzen 6000 systems which typically uses ActiveLow for IRQ1. > > > > This turned out to be a bad assumption because several vendors > > add Interrupt Source Override but don't fix the DSDT. A pile of > > quirks was collecting that proved this wasn't sustaintable. > > > > Furthermore some vendors have used ActiveHigh for IRQ1. > > To solve this problem revert the following commits: > > * commit 17bb7046e7ce ("ACPI: resource: Do IRQ override on all TongFang > > GMxRGxx") > > * commit f3cb9b740869 ("ACPI: resource: do IRQ override on Lenovo 14ALC7") > > * commit bfcdf58380b1 ("ACPI: resource: do IRQ override on LENOVO IdeaPad") > > * commit 7592b79ba4a9 ("ACPI: resource: do IRQ override on XMG Core 15") > > * commit 9946e39fe8d0 ("ACPI: resource: skip IRQ override on AMD Zen > > platforms") > > Unfortunately this breaks the keyboard on Lenovo Yoga 7 14ARB7: > https://lore.kernel.org/all/596b9c4a-fb83-a8ab-3a44-6052d83fa546@augustwikerfors.se/ > https://github.com/tomsom/yoga-linux/issues/47 Help to fix it in Linus's tree and then we will be glad to take the fix into the stable trees as well. thanks, greg k-h