From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7964EB64DD for ; Tue, 1 Aug 2023 08:02:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229917AbjHAICv (ORCPT ); Tue, 1 Aug 2023 04:02:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58134 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229585AbjHAICv (ORCPT ); Tue, 1 Aug 2023 04:02:51 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 45B9DC6 for ; Tue, 1 Aug 2023 01:02:50 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C1740614A8 for ; Tue, 1 Aug 2023 08:02:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CC75EC433C7; Tue, 1 Aug 2023 08:02:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1690876969; bh=PIBhiL9gVkjHcag2wpnES053TCbGhb7/Ld0bgtDfph0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=G+9k544Z9xJqcpAw0QsQYFoBQgWkIATCrknUfuKNEP2SIf+6BhgXy6DtrYJcOhLzh SAXAOV+6IBz3joagsIQ2OCgNGLYEz0UqTmZ5Q3d9CpMPIbFxrnga+gXhZJ9s6faKiq A6FPzo2LqI2sL9Sq33MFPx5YSumyoN1PEJV8rPD8= Date: Tue, 1 Aug 2023 10:02:46 +0200 From: Greg KH To: Jocelyn Falempe Cc: stable@vger.kernel.org, Zhang Yi , Javier Martinez Canillas , Thomas Zimmermann Subject: Re: [PATCH 4.19.y] drm/client: Fix memory leak in drm_client_target_cloned Message-ID: <2023080133-oxford-mundane-c98c@gregkh> References: <2023072326-snuff-obnoxious-af01@gregkh> <20230725120302.89913-1-jfalempe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230725120302.89913-1-jfalempe@redhat.com> Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Tue, Jul 25, 2023 at 02:02:54PM +0200, Jocelyn Falempe wrote: > dmt_mode is allocated and never freed in this function. > It was found with the ast driver, but most drivers using generic fbdev > setup are probably affected. > > This fixes the following kmemleak report: > backtrace: > [<00000000b391296d>] drm_mode_duplicate+0x45/0x220 [drm] > [<00000000e45bb5b3>] drm_client_target_cloned.constprop.0+0x27b/0x480 [drm] > [<00000000ed2d3a37>] drm_client_modeset_probe+0x6bd/0xf50 [drm] > [<0000000010e5cc9d>] __drm_fb_helper_initial_config_and_unlock+0xb4/0x2c0 [drm_kms_helper] > [<00000000909f82ca>] drm_fbdev_client_hotplug+0x2bc/0x4d0 [drm_kms_helper] > [<00000000063a69aa>] drm_client_register+0x169/0x240 [drm] > [<00000000a8c61525>] ast_pci_probe+0x142/0x190 [ast] > [<00000000987f19bb>] local_pci_probe+0xdc/0x180 > [<000000004fca231b>] work_for_cpu_fn+0x4e/0xa0 > [<0000000000b85301>] process_one_work+0x8b7/0x1540 > [<000000003375b17c>] worker_thread+0x70a/0xed0 > [<00000000b0d43cd9>] kthread+0x29f/0x340 > [<000000008d770833>] ret_from_fork+0x1f/0x30 > unreferenced object 0xff11000333089a00 (size 128): > > cc: > Fixes: 1d42bbc8f7f9 ("drm/fbdev: fix cloning on fbcon") > Reported-by: Zhang Yi > Signed-off-by: Jocelyn Falempe > Reviewed-by: Javier Martinez Canillas > Reviewed-by: Thomas Zimmermann > Link: https://patchwork.freedesktop.org/patch/msgid/20230711092203.68157-2-jfalempe@redhat.com > (cherry picked from commit c2a88e8bdf5f6239948d75283d0ae7e0c7945b03) > Signed-off-by: Jocelyn Falempe > --- > drivers/gpu/drm/drm_fb_helper.c | 5 +++++ > 1 file changed, 5 insertions(+) > Both now queued up, thanks. greg k-h