From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Mirsad Todorovac <mirsad.todorovac@alu.unizg.hr>
Cc: linux-kernel@vger.kernel.org,
Luis Chamberlain <mcgrof@kernel.org>,
Russ Weight <russell.h.weight@intel.com>,
Tianfei Zhang <tianfei.zhang@intel.com>,
Shuah Khan <shuah@kernel.org>,
Colin Ian King <colin.i.king@gmail.com>,
Randy Dunlap <rdunlap@infradead.org>,
linux-kselftest@vger.kernel.org, stable@vger.kernel.org,
Dan Carpenter <error27@gmail.com>, Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH v3 4.14 1/1] test_firmware: fix the memory leaks with the reqs buffer
Date: Mon, 7 Aug 2023 11:15:17 +0200 [thread overview]
Message-ID: <2023080705-poet-nickname-5e08@gregkh> (raw)
In-Reply-To: <20230804170017.92671-1-mirsad.todorovac@alu.unizg.hr>
On Fri, Aug 04, 2023 at 07:00:18PM +0200, Mirsad Todorovac wrote:
> [ commit be37bed754ed90b2655382f93f9724b3c1aae847 upstream ]
>
> Dan Carpenter spotted that test_fw_config->reqs will be leaked if
> trigger_batched_requests_store() is called two or more times.
> The same appears with trigger_batched_requests_async_store().
>
> This bug wasn't triggered by the tests, but observed by Dan's visual
> inspection of the code.
>
> The recommended workaround was to return -EBUSY if test_fw_config->reqs
> is already allocated.
>
> Fixes: c92316bf8e94 ("test_firmware: add batched firmware tests")
> Cc: Luis Chamberlain <mcgrof@kernel.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Russ Weight <russell.h.weight@intel.com>
> Cc: Tianfei Zhang <tianfei.zhang@intel.com>
> Cc: Shuah Khan <shuah@kernel.org>
> Cc: Colin Ian King <colin.i.king@gmail.com>
> Cc: Randy Dunlap <rdunlap@infradead.org>
> Cc: linux-kselftest@vger.kernel.org
> Cc: stable@vger.kernel.org # v4.14
> Suggested-by: Dan Carpenter <error27@gmail.com>
> Suggested-by: Takashi Iwai <tiwai@suse.de>
> Link: https://lore.kernel.org/r/20230509084746.48259-2-mirsad.todorovac@alu.unizg.hr
> Signed-off-by: Mirsad Todorovac <mirsad.todorovac@alu.unizg.hr>
>
> [ This fix is applied against the 4.14 stable branch. There are no changes to the ]
> [ fix in code when compared to the upstread, only the reformatting for backport. ]
Thanks for all of these, now queued up.
greg k-h
next prev parent reply other threads:[~2023-08-07 9:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-04 17:00 [PATCH v3 4.14 1/1] test_firmware: fix the memory leaks with the reqs buffer Mirsad Todorovac
2023-08-07 9:15 ` Greg Kroah-Hartman [this message]
2023-08-07 18:28 ` Mirsad Todorovac
2023-08-08 4:28 ` Greg Kroah-Hartman
2023-08-08 6:24 ` Mirsad Todorovac
2023-08-08 7:35 ` Greg Kroah-Hartman
2023-08-08 19:26 ` Mirsad Todorovac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023080705-poet-nickname-5e08@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=colin.i.king@gmail.com \
--cc=error27@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=mirsad.todorovac@alu.unizg.hr \
--cc=rdunlap@infradead.org \
--cc=russell.h.weight@intel.com \
--cc=shuah@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tianfei.zhang@intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox