From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FF0EC001B0 for ; Wed, 9 Aug 2023 11:07:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233130AbjHILHL (ORCPT ); Wed, 9 Aug 2023 07:07:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45414 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233122AbjHILHL (ORCPT ); Wed, 9 Aug 2023 07:07:11 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C7275ED for ; Wed, 9 Aug 2023 04:07:10 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 58E3762BD5 for ; Wed, 9 Aug 2023 11:07:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 68938C433C7; Wed, 9 Aug 2023 11:07:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1691579229; bh=tKQrkz/5rZVBMSqWA0y0LTMpROCcSLSibUxn/l9zsaA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=xV9DryJMjoF3AoIXUoD+RSjcftPknFXNh21sLUUHBzelAk1/iG22Nmbe+3cuy2Tmq LEd63fJJiv++JH7S+3QrShefM2R4y3D6+tba+ZO0qxPtQQyp+JufwW15GPoVOJl2Kz 50YKJd1+c2s1yIZqSJmqduTcxHZ6XRNA0ucxjAzA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Shreyas Deodhar , Nilesh Javali , Himanshu Madhani , "Martin K. Petersen" Subject: [PATCH 4.14 122/204] scsi: qla2xxx: Pointer may be dereferenced Date: Wed, 9 Aug 2023 12:41:00 +0200 Message-ID: <20230809103646.688968133@linuxfoundation.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230809103642.552405807@linuxfoundation.org> References: <20230809103642.552405807@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Shreyas Deodhar commit 00eca15319d9ce8c31cdf22f32a3467775423df4 upstream. Klocwork tool reported pointer 'rport' returned from call to function fc_bsg_to_rport() may be NULL and will be dereferenced. Add a fix to validate rport before dereferencing. Cc: stable@vger.kernel.org Signed-off-by: Shreyas Deodhar Signed-off-by: Nilesh Javali Link: https://lore.kernel.org/r/20230607113843.37185-7-njavali@marvell.com Reviewed-by: Himanshu Madhani Signed-off-by: Martin K. Petersen Signed-off-by: Greg Kroah-Hartman --- drivers/scsi/qla2xxx/qla_bsg.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/scsi/qla2xxx/qla_bsg.c +++ b/drivers/scsi/qla2xxx/qla_bsg.c @@ -2493,6 +2493,8 @@ qla24xx_bsg_request(struct bsg_job *bsg_ if (bsg_request->msgcode == FC_BSG_RPT_ELS) { rport = fc_bsg_to_rport(bsg_job); + if (!rport) + return ret; host = rport_to_shost(rport); vha = shost_priv(host); } else {