From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82A86C001DB for ; Sun, 13 Aug 2023 16:11:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232769AbjHMQL0 (ORCPT ); Sun, 13 Aug 2023 12:11:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46404 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232958AbjHMQLE (ORCPT ); Sun, 13 Aug 2023 12:11:04 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 00D9735AF; Sun, 13 Aug 2023 09:10:38 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BDAAE63A65; Sun, 13 Aug 2023 16:09:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 83F7BC433CA; Sun, 13 Aug 2023 16:09:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691942988; bh=uIkzi3MpeaquzFsir9NCDcM8HNJILcdPwSbHMHvylpw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fmkl6OxGUAlipAbTdJZjxJkAp7pDzEAzWk+LaC6jsRyCNSNR2o0UJTL7ODvDQdnM4 HFTRaMMiNNeSSMXUTXaOFFOUpCl2jOk5TqbxiHoLXISh2+vKpe4sCv+OgoqelKdtY/ OGPCPRbvIBNDEW2cjzYpBtEaCotloNGVarUmwJMFNlqhaosGDgXBPR/l9tdwG9Bbeb uxgel/cXDBAhClLA9rZqumbDcfkU9ZSwNuHXR10s8REmt+6rBQYXVL8a7SHqBKaKo6 z+Mkp/6Vuw6RlWRVM/RZo97+//XqDnSmWmfTb8hNHoudcGQJT2PcZjKrmtLaXUVpU9 7kdshVIZ4sFWw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Dmitry Antipov , Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin , hverkuil@xs4all.nl, linux-media@vger.kernel.org Subject: [PATCH AUTOSEL 5.10 03/25] media: pulse8-cec: handle possible ping error Date: Sun, 13 Aug 2023 12:09:14 -0400 Message-Id: <20230813160936.1082758-3-sashal@kernel.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230813160936.1082758-1-sashal@kernel.org> References: <20230813160936.1082758-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.10.190 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Dmitry Antipov [ Upstream commit 92cbf865ea2e0f2997ff97815c6db182eb23df1b ] Handle (and warn about) possible error waiting for MSGCODE_PING result. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Dmitry Antipov Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/cec/usb/pulse8/pulse8-cec.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/media/cec/usb/pulse8/pulse8-cec.c b/drivers/media/cec/usb/pulse8/pulse8-cec.c index 04b13cdc38d2c..ba67587bd43ec 100644 --- a/drivers/media/cec/usb/pulse8/pulse8-cec.c +++ b/drivers/media/cec/usb/pulse8/pulse8-cec.c @@ -809,8 +809,11 @@ static void pulse8_ping_eeprom_work_handler(struct work_struct *work) mutex_lock(&pulse8->lock); cmd = MSGCODE_PING; - pulse8_send_and_wait(pulse8, &cmd, 1, - MSGCODE_COMMAND_ACCEPTED, 0); + if (pulse8_send_and_wait(pulse8, &cmd, 1, + MSGCODE_COMMAND_ACCEPTED, 0)) { + dev_warn(pulse8->dev, "failed to ping EEPROM\n"); + goto unlock; + } if (pulse8->vers < 2) goto unlock; -- 2.40.1