From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C7C4EB64DD for ; Sun, 13 Aug 2023 21:30:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231856AbjHMVaE (ORCPT ); Sun, 13 Aug 2023 17:30:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42180 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231836AbjHMVaD (ORCPT ); Sun, 13 Aug 2023 17:30:03 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D44A810D7 for ; Sun, 13 Aug 2023 14:30:05 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6C8D062AE7 for ; Sun, 13 Aug 2023 21:30:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 853B5C433C8; Sun, 13 Aug 2023 21:30:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1691962204; bh=wXT+SuCdLrZhpCZTgn2OQu56utFFQ/y5yNhZdGV1OmE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=xj0sCsRupy77I+jaL1Pyw/EiHfCyQzHiIXwlv3vUrLgeQdTkF8q8tGjGDUw5r8dk1 dhj8ZYPFrYA0QwNT4RZyJ06vO44lQLQw2Rmy4LKYRIviGaKm0Qpspr2zpKJdlKrwaQ Lvtr7lx6NWn0fPUosQLgYsb0CegU1Bja2hXzyZFc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Kalesh AP , Selvin Xavier , Jason Gunthorpe Subject: [PATCH 6.4 151/206] RDMA/bnxt_re: Fix error handling in probe failure path Date: Sun, 13 Aug 2023 23:18:41 +0200 Message-ID: <20230813211729.353036405@linuxfoundation.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230813211724.969019629@linuxfoundation.org> References: <20230813211724.969019629@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Kalesh AP commit 5ac8480ae4d01f0ca5dfd561884424046df2478a upstream. During bnxt_re_dev_init(), when bnxt_re_setup_chip_ctx() fails unregister with L2 first before bailing out probe. Fixes: ae8637e13185 ("RDMA/bnxt_re: Add chip context to identify 57500 series") Link: https://lore.kernel.org/r/1691642677-21369-3-git-send-email-selvin.xavier@broadcom.com Signed-off-by: Kalesh AP Signed-off-by: Selvin Xavier Signed-off-by: Jason Gunthorpe Signed-off-by: Greg Kroah-Hartman --- drivers/infiniband/hw/bnxt_re/main.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/infiniband/hw/bnxt_re/main.c +++ b/drivers/infiniband/hw/bnxt_re/main.c @@ -1152,6 +1152,8 @@ static int bnxt_re_dev_init(struct bnxt_ rc = bnxt_re_setup_chip_ctx(rdev, wqe_mode); if (rc) { + bnxt_unregister_dev(rdev->en_dev); + clear_bit(BNXT_RE_FLAG_NETDEV_REGISTERED, &rdev->flags); ibdev_err(&rdev->ibdev, "Failed to get chip context\n"); return -EINVAL; }