From: Greg KH <greg@kroah.com>
To: Karol Herbst <kherbst@redhat.com>
Cc: stable@vger.kernel.org, Lyude Paul <lyude@redhat.com>
Subject: Re: [PATCH 6.1.y] drm/nouveau/disp: fix use-after-free in error handling of nouveau_connector_create
Date: Mon, 21 Aug 2023 20:44:56 +0200 [thread overview]
Message-ID: <2023082147-stuck-snowplow-ff06@gregkh> (raw)
In-Reply-To: <20230821175918.639815-1-kherbst@redhat.com>
On Mon, Aug 21, 2023 at 07:59:18PM +0200, Karol Herbst wrote:
> We can't simply free the connector after calling drm_connector_init on it.
> We need to clean up the drm side first.
>
> It might not fix all regressions from commit 2b5d1c29f6c4
> ("drm/nouveau/disp: PIOR DP uses GPIO for HPD, not PMGR AUX interrupts"),
> but at least it fixes a memory corruption in error handling related to
> that commit.
>
> Link: https://lore.kernel.org/lkml/20230806213107.GFZNARG6moWpFuSJ9W@fat_crate.local/
> Fixes: 95983aea8003 ("drm/nouveau/disp: add connector class")
> Signed-off-by: Karol Herbst <kherbst@redhat.com>
> Reviewed-by: Lyude Paul <lyude@redhat.com>
> Link: https://patchwork.freedesktop.org/patch/msgid/20230814144933.3956959-1-kherbst@redhat.com
> (cherry picked from commit 1b254b791d7b7dea6e8adc887fbbd51746d8bb27)
> Signed-off-by: Karol Herbst <kherbst@redhat.com>
> ---
> drivers/gpu/drm/nouveau/nouveau_connector.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
Now queued up, thanks.
greg k-h
prev parent reply other threads:[~2023-08-21 19:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-21 17:03 FAILED: patch "[PATCH] drm/nouveau/disp: fix use-after-free in error handling of" failed to apply to 6.1-stable tree gregkh
2023-08-21 17:59 ` [PATCH 6.1.y] drm/nouveau/disp: fix use-after-free in error handling of nouveau_connector_create Karol Herbst
2023-08-21 18:44 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023082147-stuck-snowplow-ff06@gregkh \
--to=greg@kroah.com \
--cc=kherbst@redhat.com \
--cc=lyude@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox