From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Alexandra Diupina <adiupina@astralinux.ru>
Cc: Joerg Roedel <joro@8bytes.org>,
stable@vger.kernel.org, Will Deacon <will@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
iommu@lists.linux-foundation.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [PATCH 5.10] iommu/mediatek: remove redundant comparison
Date: Thu, 24 Aug 2023 15:13:47 +0200 [thread overview]
Message-ID: <2023082441-sulfide-abstain-fffa@gregkh> (raw)
In-Reply-To: <20230824130954.29688-1-adiupina@astralinux.ru>
On Thu, Aug 24, 2023 at 04:09:54PM +0300, Alexandra Diupina wrote:
> iommu_device_register always returns 0 in 4.11-5.12, so
> we need to remove redundant comparison with 0
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: b16c0170b53c ("iommu/mediatek: Make use of iommu_device_register interface")
> Signed-off-by: Alexandra Diupina <adiupina@astralinux.ru>
> ---
> drivers/iommu/mtk_iommu.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c
> index 051815c9d2bb..208c47218b75 100644
> --- a/drivers/iommu/mtk_iommu.c
> +++ b/drivers/iommu/mtk_iommu.c
> @@ -748,9 +748,7 @@ static int mtk_iommu_probe(struct platform_device *pdev)
> iommu_device_set_ops(&data->iommu, &mtk_iommu_ops);
> iommu_device_set_fwnode(&data->iommu, &pdev->dev.of_node->fwnode);
>
> - ret = iommu_device_register(&data->iommu);
> - if (ret)
> - return ret;
> + iommu_device_register(&data->iommu);
>
> spin_lock_init(&data->tlb_lock);
> list_add_tail(&data->list, &m4ulist);
> --
> 2.30.2
>
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.
</formletter>
next prev parent reply other threads:[~2023-08-24 13:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-24 13:09 [PATCH] [PATCH 5.10] iommu/mediatek: remove redundant comparison Alexandra Diupina
2023-08-24 13:13 ` Greg Kroah-Hartman
2023-08-24 13:13 ` Greg Kroah-Hartman [this message]
2023-08-24 13:15 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023082441-sulfide-abstain-fffa@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=adiupina@astralinux.ru \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=stable@vger.kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox