public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Patrick Rohr <prohr@google.com>
Cc: stable@vger.kernel.org, "Maciej Żenczykowski" <maze@google.com>,
	"Lorenzo Colitti" <lorenzo@google.com>
Subject: Re: [PATCH 6.1] net: add sysctl accept_ra_min_lft
Date: Fri, 25 Aug 2023 08:13:59 +0200	[thread overview]
Message-ID: <2023082503-humorous-thieving-b162@gregkh> (raw)
In-Reply-To: <20230824223225.863719-1-prohr@google.com>

On Thu, Aug 24, 2023 at 03:32:25PM -0700, Patrick Rohr wrote:
> This change adds a new sysctl accept_ra_min_lft which enforces a minimum
> lifetime value for individual RA sections; in particular, router
> lifetime, PIO preferred lifetime, and RIO lifetime. If any of those
> lifetimes are lower than the configured value, the specific RA section
> is ignored.
> 
> This fixes a potential denial of service attack vector where rogue WiFi
> routers (or devices) can send RAs with low lifetimes to actively drain a
> mobile device's battery (by preventing sleep).
> 
> In addition to this change, Android uses hardware offloads to drop RAs
> for a fraction of the minimum of all lifetimes present in the RA (some
> networks have very frequent RAs (5s) with high lifetimes (2h)). Despite
> this, we have encountered networks that set the router lifetime to 30s
> which results in very frequent CPU wakeups. Instead of disabling IPv6
> (and dropping IPv6 ethertype in the WiFi firmware) entirely on such
> networks, misconfigured routers must be ignored while still processing
> RAs from other IPv6 routers on the same network (i.e. to support IoT
> applications).
> 
> This change squashes the following patches into a single commit:
> - net-next 1671bcfd76fd ("net: add sysctl accept_ra_min_rtr_lft")
> - net-next 5027d54a9c30 ("net: change accept_ra_min_rtr_lft to affect all RA lifetimes")
> - net-next 5cb249686e67 ("net: release reference to inet6_dev pointer")

Please don't do this.  We want the original commits into the stable
tree, after they have landed in Linus's tree.

Please read:
    https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

thanks,

greg k-h

      reply	other threads:[~2023-08-25  8:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-24 22:32 [PATCH 6.1] net: add sysctl accept_ra_min_lft Patrick Rohr
2023-08-25  6:13 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2023082503-humorous-thieving-b162@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=lorenzo@google.com \
    --cc=maze@google.com \
    --cc=prohr@google.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox