From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4414FC83F19 for ; Mon, 28 Aug 2023 10:16:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230386AbjH1KQ0 (ORCPT ); Mon, 28 Aug 2023 06:16:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46806 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230398AbjH1KP5 (ORCPT ); Mon, 28 Aug 2023 06:15:57 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F2AA795 for ; Mon, 28 Aug 2023 03:15:54 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 88D1B617E4 for ; Mon, 28 Aug 2023 10:15:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9BF7BC433C8; Mon, 28 Aug 2023 10:15:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1693217754; bh=qgP0zrs1RgUyd3HTs/EQDkHrD9MILVAC2O0XKnvwi8w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MiyBVJFljPM4Leu/ca84yrN/sOXC19uEmCNqs8t9O46V1wxq3QXK2AtAqzry79mxa sVYlvaR6GUOdyyv6appApVUuapcLG5YgpaFvFCXUUZl7YpuNnRI6fWb80lexvP29J0 AB8yiu3fcvYEAeBiqLpo1Qpos7mQdG6bwQpfHpVk= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Immad Mir , Dave Kleikamp , Sasha Levin Subject: [PATCH 4.14 10/57] FS: JFS: Check for read-only mounted filesystem in txBegin Date: Mon, 28 Aug 2023 12:12:30 +0200 Message-ID: <20230828101144.577715264@linuxfoundation.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20230828101144.231099710@linuxfoundation.org> References: <20230828101144.231099710@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Immad Mir [ Upstream commit 95e2b352c03b0a86c5717ba1d24ea20969abcacc ] This patch adds a check for read-only mounted filesystem in txBegin before starting a transaction potentially saving from NULL pointer deref. Signed-off-by: Immad Mir Signed-off-by: Dave Kleikamp Signed-off-by: Sasha Levin --- fs/jfs/jfs_txnmgr.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/fs/jfs/jfs_txnmgr.c b/fs/jfs/jfs_txnmgr.c index 224ef034004b7..2cb460912468e 100644 --- a/fs/jfs/jfs_txnmgr.c +++ b/fs/jfs/jfs_txnmgr.c @@ -367,6 +367,11 @@ tid_t txBegin(struct super_block *sb, int flag) jfs_info("txBegin: flag = 0x%x", flag); log = JFS_SBI(sb)->log; + if (!log) { + jfs_error(sb, "read-only filesystem\n"); + return 0; + } + TXN_LOCK(); INCREMENT(TxStat.txBegin); -- 2.40.1