From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Nathan Chancellor <nathan@kernel.org>
Cc: Sasha Levin <sashal@kernel.org>,
stable@vger.kernel.org, llvm@lists.linux.dev,
Nick Desaulniers <ndesaulniers@google.com>,
Michael Ellerman <mpe@ellerman.id.au>
Subject: Re: Apply 9451c79bc39e610882bdd12370f01af5004a3c4f to linux-5.4.y
Date: Wed, 30 Aug 2023 17:39:18 +0200 [thread overview]
Message-ID: <2023083056-figure-plasma-1774@gregkh> (raw)
In-Reply-To: <20230830153342.GA888898@dev-arch.thelio-3990X>
On Wed, Aug 30, 2023 at 08:33:42AM -0700, Nathan Chancellor wrote:
> Hi Greg and Sasha,
>
> Please consider applying commit 9451c79bc39e ("powerpc/pmac/smp: Avoid
> unused-variable warnings") to 5.4, as it resolves a build failure that
> we see building ppc64_guest_defconfig with clang due to arch/powerpc
> compiling with -Werror by default:
>
> arch/powerpc/platforms/powermac/smp.c:664:26: error: unused variable 'core99_l2_cache' [-Werror,-Wunused-variable]
> 664 | volatile static long int core99_l2_cache;
> | ^~~~~~~~~~~~~~~
> arch/powerpc/platforms/powermac/smp.c:665:26: error: unused variable 'core99_l3_cache' [-Werror,-Wunused-variable]
> 665 | volatile static long int core99_l3_cache;
> | ^~~~~~~~~~~~~~~
> 2 errors generated.
>
> I have verified that it applies cleanly and does not appear to have any
> direct follow up fixes, although commit a4037d1f1fc4 ("powerpc/pmac/smp:
> Drop unnecessary volatile qualifier") was in the same area around the
> same time so maybe it makes sense to take that one as well but I don't
> think it has any functional impact.
Now queued up.
greg k-h
prev parent reply other threads:[~2023-08-30 18:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-30 15:33 Apply 9451c79bc39e610882bdd12370f01af5004a3c4f to linux-5.4.y Nathan Chancellor
2023-08-30 15:39 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023083056-figure-plasma-1774@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=llvm@lists.linux.dev \
--cc=mpe@ellerman.id.au \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox